1095474 - Intermittent /indexedDB/test/test_file_replace.html | application terminated with exit code 1

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Carsten Book [:Tomcat]]

Ubuntu ASAN VM 12.04 x64 mozilla-central opt test mochitest-e10s-2

https://treeherder.mozilla.org/ui/logviewer.html#?job_id=598214&repo=mozilla-central

04:57:40 INFO - 1648 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/indexedDB/test/test_file_replace.html | application terminated with exit code 1

Comment 1

[Legacy TBPL/Treeherder Robot]

submit_timestamp: 2014-11-07T05:50:03
log: https://treeherder.mozilla.org/ui/logviewer.html#?repo=mozilla-central&job_id=598214
repository: mozilla-central
who: tomcat[at]mozilla[dot]com
machine: tst-linux64-spot-270
buildname: Ubuntu ASAN VM 12.04 x64 mozilla-central opt test mochitest-e10s-2
revision: 64f4392d0bdc

SUMMARY: AddressSanitizer: heap-use-after-free /tools/gcc-4.7.3-0moz1/lib/gcc/x86_64-unknown-linux-gnu/4.7.3/../../../../include/c++/4.7.3/bits/atomic_base.h:444 store
1648 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/indexedDB/test/test_file_replace.html | application terminated with exit code 1
Return code: 1

Comment 2

[Legacy TBPL/Treeherder Robot]

submit_timestamp: 2014-11-11T01:45:37
log: https://treeherder.mozilla.org/ui/logviewer.html#?repo=b2g-inbound&job_id=811517
repository: b2g-inbound
who: tomcat[at]mozilla[dot]com
machine: tst-linux32-spot-713
buildname: Ubuntu VM 12.04 b2g-inbound debug test mochitest-e10s-2
revision: 61a766b04318

1646 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/indexedDB/test/test_file_replace.html | application terminated with exit code 11
PROCESS-CRASH | /tests/dom/indexedDB/test/test_file_replace.html | application crashed [@ 0x0]
TEST-UNEXPECTED-FAIL | leakcheck | default process: missing output line for total leaks!
Return code: 1

Comment 3

[Jan Varga [:janv]]

Attachment: fix

Comment 4

[Legacy TBPL/Treeherder Robot]

submit_timestamp: 2014-11-11T11:32:47
log: https://treeherder.mozilla.org/ui/logviewer.html#?repo=try&job_id=3085388
repository: try
who: jmathies[at]mozilla[dot]com
machine: tst-linux64-spot-1120
buildname: Ubuntu ASAN VM 12.04 x64 try opt test mochitest-e10s-2
revision: 32ed9f0ddab6

SUMMARY: AddressSanitizer: heap-use-after-free /tools/gcc-4.7.3-0moz1/lib/gcc/x86_64-unknown-linux-gnu/4.7.3/../../../../include/c++/4.7.3/bits/atomic_base.h:444 store
1664 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/indexedDB/test/test_file_replace.html | application terminated with exit code 1
Return code: 1

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8520617 [details] [diff] [review]
fix

Review of attachment 8520617 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: dom/indexedDB/FileInfo.cpp
@@ +182,5 @@
> +  IndexedDatabaseManager::FileMutex().AssertCurrentThreadOwns();
> +
> +  mDBRefCnt = 0;
> +
> +  if (mRefCnt + mDBRefCnt + mSliceRefCnt > 0) {

You just set mDBRefCnt to 0 so no need to add it here. Just do:

  if (mRefCnt || mSliceRefCnt) {

Comment 6

[Jan Varga [:janv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/622448fd70ad

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/622448fd70ad

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Does the underlying defect affect any older branches?

Comment 9

[Jan Varga [:janv]]

Yes, it does. It goes far back to the release history.
The fact that we now clear origins after each test and that we now have ASAN, revealed this defect.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for at least Aurora uplift. Maybe beta too (not sure if it's severe enough to warrant landing just before the final beta goes to build, though).

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Let's just focus on Aurora approval.

Comment 12

[Jan Varga [:janv]]

Comment on attachment 8520617 [details] [diff] [review]
fix

Approval Request Comment
[Feature/regressing bug #]: Enable storing files in IndexedDB, bug 661877.
[User impact if declined]: The browser can sometimes crash when an origin is being cleared and stored files are involved.
[Describe test coverage new/current, TBPL]: Origins are cleared before and after each mochitest.
[Risks and why]: The patch should be safe and can be easily reverted.
[String/UUID change made/needed]: No string/UUID changes.

Comment 13

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 8520617 [details] [diff] [review]
fix

Approving as it's a good crash fix - ni? Lawrence - since we're taking an extra week on Beta for 34 perhaps you might want this there as well?

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/503c939cc2fc

Comment 15

[Lawrence Mandel [:lmandel] (use needinfo)]

The overall crash rate for 34 is good so we don't need to take additional stability fixes in this release. Given that it is late in the cycle, I passed on this one for 34.