Intermittent /indexedDB/test/test_file_replace.html | application terminated with exit code 1

RESOLVED FIXED in Firefox 35

Status

()

Core
DOM: IndexedDB
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Tomcat, Assigned: janv)

Tracking

({intermittent-failure})

Trunk
mozilla36
All
Linux
intermittent-failure
Points:
---

Firefox Tracking Flags

(firefox34 wontfix, firefox35 fixed, firefox36 fixed, firefox-esr31 unaffected)

Details

(URL)

Attachments

(1 attachment)

fix
4.84 KB, patch
Ben Turner (not reading bugmail, use the needinfo flag!)
: review+
Details | Diff | Splinter Review
(Reporter)

Description

3 years ago
Ubuntu ASAN VM 12.04 x64 mozilla-central opt test mochitest-e10s-2

https://treeherder.mozilla.org/ui/logviewer.html#?job_id=598214&repo=mozilla-central

04:57:40 INFO - 1648 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/indexedDB/test/test_file_replace.html | application terminated with exit code 1
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 3

3 years ago
Created attachment 8520617 [details] [diff] [review]
fix
Assignee: nobody → Jan.Varga
Status: NEW → ASSIGNED
Attachment #8520617 - Flags: review?(bent.mozilla)
Comment hidden (Treeherder Robot)
Comment on attachment 8520617 [details] [diff] [review]
fix

Review of attachment 8520617 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: dom/indexedDB/FileInfo.cpp
@@ +182,5 @@
> +  IndexedDatabaseManager::FileMutex().AssertCurrentThreadOwns();
> +
> +  mDBRefCnt = 0;
> +
> +  if (mRefCnt + mDBRefCnt + mSliceRefCnt > 0) {

You just set mDBRefCnt to 0 so no need to add it here. Just do:

  if (mRefCnt || mSliceRefCnt) {
Attachment #8520617 - Flags: review?(bent.mozilla) → review+
(Assignee)

Comment 6

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/622448fd70ad
(Reporter)

Comment 7

3 years ago
https://hg.mozilla.org/mozilla-central/rev/622448fd70ad
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Does the underlying defect affect any older branches?
status-firefox34: --- → ?
status-firefox35: --- → ?
status-firefox36: --- → fixed
status-firefox-esr31: --- → unaffected
Flags: needinfo?(Jan.Varga)
(Assignee)

Comment 9

3 years ago
Yes, it does. It goes far back to the release history.
The fact that we now clear origins after each test and that we now have ASAN, revealed this defect.
Flags: needinfo?(Jan.Varga)
Please nominate this for at least Aurora uplift. Maybe beta too (not sure if it's severe enough to warrant landing just before the final beta goes to build, though).
status-firefox34: ? → affected
status-firefox35: ? → affected
Let's just focus on Aurora approval.
status-firefox34: affected → wontfix
(Assignee)

Comment 12

3 years ago
Comment on attachment 8520617 [details] [diff] [review]
fix

Approval Request Comment
[Feature/regressing bug #]: Enable storing files in IndexedDB, bug 661877.
[User impact if declined]: The browser can sometimes crash when an origin is being cleared and stored files are involved.
[Describe test coverage new/current, TBPL]: Origins are cleared before and after each mochitest.
[Risks and why]: The patch should be safe and can be easily reverted.
[String/UUID change made/needed]: No string/UUID changes.
Attachment #8520617 - Flags: approval-mozilla-aurora?
Comment on attachment 8520617 [details] [diff] [review]
fix

Approving as it's a good crash fix - ni? Lawrence - since we're taking an extra week on Beta for 34 perhaps you might want this there as well?
Flags: needinfo?(lmandel)
Attachment #8520617 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/503c939cc2fc
status-firefox35: affected → fixed
The overall crash rate for 34 is good so we don't need to take additional stability fixes in this release. Given that it is late in the cycle, I passed on this one for 34.
Flags: needinfo?(lmandel)
You need to log in before you can comment on or make changes to this bug.