Closed
Bug 1095514
Opened 10 years ago
Closed 10 years ago
Intermittent testDistribution | Exception caught - junit.framework.ComparisonFailure: expected:<......> but was:<...,"pin":true...>
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox34 unaffected, firefox35 fixed, firefox36 fixed, firefox-esr31 unaffected)
RESOLVED
FIXED
Firefox 36
Tracking | Status | |
---|---|---|
firefox34 | --- | unaffected |
firefox35 | --- | fixed |
firefox36 | --- | fixed |
firefox-esr31 | --- | unaffected |
People
(Reporter: cbook, Assigned: bnicholson)
References
()
Details
(Keywords: intermittent-failure)
Attachments
(1 file, 1 obsolete file)
5.15 KB,
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
Android 2.3 Emulator mozilla-central opt test robocop-1 https://treeherder.mozilla.org/ui/logviewer.html#?job_id=597935&repo=mozilla-central 04:52:15 WARNING - TEST-UNEXPECTED-FAIL | testDistribution | Exception caught - junit.framework.ComparisonFailure: expected:<......> but was:<...,"pin":true...>
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Updated•10 years ago
|
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 8•10 years ago
|
||
Screenshot
Comment 9•10 years ago
|
||
All of the current failures are Android 2.3 emulator runs.
Assignee | ||
Comment 10•10 years ago
|
||
Made a try build this morning to add a couple waitForTexts in the pin site code. Let's see if it helps: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=8b05b71c5eba
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 21•10 years ago
|
||
After clicking Pin Site, there is a small delay before the top site item is actually pinned, and we occasionally click the tile before its pinned state has been updated. This creates a verifyPinned helper, along with some additional assertions/fixes to make the test more robust. https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=dbf5a5f3e77f
Attachment #8519196 -
Attachment is obsolete: true
Attachment #8520776 -
Flags: review?(rnewman)
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 23•10 years ago
|
||
Comment on attachment 8520776 [details] [diff] [review] Make distribution tile tests more robust Review of attachment 8520776 [details] [diff] [review]: ----------------------------------------------------------------- Sounds fair to me!
Attachment #8520776 -
Flags: review?(rnewman) → review+
Assignee | ||
Comment 24•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/217c7f7d9f48
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 26•10 years ago
|
||
Comment on attachment 8520776 [details] [diff] [review] Make distribution tile tests more robust Approval Request Comment [Feature/regressing bug #]: Failures caused by tests added in bug 1068425. [User impact if declined]: Intermittent test failures. [Describe test coverage new/current, TBPL]: Failure is gone in try push (comment 21). [Risks and why]: No risk (test-only fix). [String/UUID change made/needed]: None.
Attachment #8520776 -
Flags: approval-mozilla-aurora?
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
https://hg.mozilla.org/mozilla-central/rev/217c7f7d9f48
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Comment 30•10 years ago
|
||
Comment on attachment 8520776 [details] [diff] [review] Make distribution tile tests more robust Test-only changes don't need approval. SHIP IT.
Attachment #8520776 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
status-firefox34:
--- → wontfix
status-firefox35:
--- → affected
status-firefox36:
--- → fixed
status-firefox-esr31:
--- → unaffected
Comment 31•10 years ago
|
||
That said, the subtests in question don't exist on Aurora?
Comment 32•10 years ago
|
||
Ah, bug 1068425 hasn't been uplifted yet.
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•