1095529 - [ftu] js/language.js LanguageManager defined and initialized LanguageManager.init() in some place

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[sv99]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20141105030203



Actual results:

Error in unit tests environment - problems in LanguageManager.init() - wich requierd:
1) document.querySelector('#languages ul');
2) LanguageList.get 

test-agent load requireApp('ftu/js/language.js'); and in console we have script error

Comment 1

[sv99]

Attachment: Link to PR

Comment 2

[sv99]

in js/app.js other components initialized in method init
var AppManager = {

  init: function init(versionInfo) {
    this.isInitialized = true;

    UIManager.init();
    Navigation.init();
...
    SimManager.init();
    WifiManager.init();
    ImportIntegration.init();
    TimeManager.init();
    DataMobile.init();
    Tutorial.init();

but LanguageManager init in some place were defined??

Comment 3

[Sam Foster [:sfoster] (he/him)]

I think your PR has the right idea, LanguageManager should be initialized in AppManager, I dislike modules that initialize themselves instantly - makes sequencing difficult. Actually I'd like to refactor this at some point so the knowledge of the document structure in buildLanguageList moves to UIManager. I can take the review of this.

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8518995 [details] [review]
Link to PR

Forwarding this to Sam.

Comment 5

[sv99]

My PR remove some annoying error messages when test-agent initialized test suite for FTU.
I don't have enough experience for rewriting this application. This changes may be made in another bug??

Thanks

Comment 6

[Sam Foster [:sfoster] (he/him)]

> My PR remove some annoying error messages when test-agent initialized test
> suite for FTU.
> I don't have enough experience for rewriting this application. This changes
> may be made in another bug??

Yes absolutely, I didn't mean for you to try and do any rewriting here.

Comment 7

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8518995 [details] [review]
Link to PR

Gaia-Try looks good, thanks for tidying this up. r=me

Comment 8

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/59063be9cab6997540c927584c2ff3ceaaeff924