1095541 - break nsRefPtr.h's dependence on nsCOMPtr.h

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Nathan Froyd [:froydnj]]

Breaking the dependence requires doing two things:

1. Moving already_AddRefed to some common place that nsCOMPtr.h and nsRefPtr.h can use.
2. Ensuring that the nsRefPtr constructor/operator= nsCOMPtr_helper overloads don't require a complete definition of nsCOMPtr_helper until they are actually used.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: part 1 - move nsRefPtr nsCOMPtr_helper overloads out-of-line

Doing this means that instantiations of nsRefPtr<T> won't require
nsCOMPtr_helper::operator() to be defined.  Only actual uses of the
overloads will require the definition.

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: part 2 - move already_AddRefed to its own header file

Comment 3

[Nathan Froyd [:froydnj]]

Attachment: part 3 - remove nsCOMPtr.h #include from nsRefPtr.h

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d0dc5b25a765
https://hg.mozilla.org/mozilla-central/rev/cf6287a13927
https://hg.mozilla.org/mozilla-central/rev/97408585e41c