Closed Bug 1095593 Opened 7 years ago Closed 7 years ago

Morgan Phillips (mrrrgn) needs production commiter rights on puppet again.

Categories

(Developer Services :: Mercurial: hg.mozilla.org, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mrrrgn, Assigned: pmoore)

Details

(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/4115] )

Attachments

(2 files, 1 obsolete file)

No description provided.
Hi Morgan,

Can you confirm you are not able to push to:

ssh://hg.mozilla.org/build/puppet

when using your ldap key?

Thanks,
Pete
Flags: needinfo?(winter2718)
(In reply to Pete Moore [:pete][:pmoore] from comment #1)
> Hi Morgan,
> 
> Can you confirm you are not able to push to:
> 
> ssh://hg.mozilla.org/build/puppet
> 
> when using your ldap key?
> 
> Thanks,
> Pete

Hi Pete,

I'm able to push to the default branch; but if I make any changes to the production branch it's denied.
Flags: needinfo?(winter2718)
Component: Other → Mercurial: hg.mozilla.org
Product: Release Engineering → Developer Services
QA Contact: pmoore → hwine
Thanks Morgan!

Fubar,
Would you be able to grant Morgan write permission to production branch of build/puppet hg repo?
Is that something we should request from you, or can RelEng self-serve on granting permissions there?
Do you information about how this access is managed, and do we have a way to see which users currently have write permission to this branch (so we can audit it)?
Thanks,
Pete
Flags: needinfo?(klibby)
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/4115]
Adding Morgan Phillips <winter2718@gmail.com> to the list of people entitled to push to production branch of releng repos, and removing people who left releng from the list.
Assignee: nobody → pmoore
Status: NEW → ASSIGNED
Attachment #8522062 - Flags: review?(mgervasini)
Attachment #8522062 - Flags: review?(mgervasini) → review+
Morgan,

It has just occurred to me that the email address we add here in this list should be the ssh user that you connect with over to hg.mozilla.org with (i.e. the User from your ~/.ssh/config for hg.mozilla.org), if different from the email address that you commit with.

Can you confirm if this is also winter2718@gmail.com or if it is something else such as mphillips@mozilla.com.

Thanks,
Pete
Flags: needinfo?(winter2718)
(In reply to Pete Moore [:pete][:pmoore] from comment #6)
> Morgan,
> 
> It has just occurred to me that the email address we add here in this list
> should be the ssh user that you connect with over to hg.mozilla.org with
> (i.e. the User from your ~/.ssh/config for hg.mozilla.org), if different
> from the email address that you commit with.
> 
> Can you confirm if this is also winter2718@gmail.com or if it is something
> else such as mphillips@mozilla.com.
> 
> Thanks,
> Pete

Oh, yes, my ssh email is mphillips@mozilla.com -- thanks so much for setting me up with access! :)
Flags: needinfo?(winter2718)
Hi Massimo,

I already checked the previous patch in, so this is an incremental patch on top of the last one.

I'm assuming Callek connects to hg.mozilla.org over ssh with user jwood@mozilla.com so I'm removing his gmail entry too (just some spring cleaning).

We can always add it back if I am wrong. I did ask in channel so if he pings me later, I can re-add it.

Pete
Attachment #8522264 - Flags: review?(mgervasini)
(In reply to Morgan Phillips [:mrrrgn] from comment #7)
> (In reply to Pete Moore [:pete][:pmoore] from comment #6)
> > Morgan,
> > 
> > It has just occurred to me that the email address we add here in this list
> > should be the ssh user that you connect with over to hg.mozilla.org with
> > (i.e. the User from your ~/.ssh/config for hg.mozilla.org), if different
> > from the email address that you commit with.
> > 
> > Can you confirm if this is also winter2718@gmail.com or if it is something
> > else such as mphillips@mozilla.com.
> > 
> > Thanks,
> > Pete
> 
> Oh, yes, my ssh email is mphillips@mozilla.com -- thanks so much for setting
> me up with access! :)

You are very welcome! =)
Comment on attachment 8522264 [details] [diff] [review]
bug1095593_version-control-tools_v2.patch

Review of attachment 8522264 [details] [diff] [review]:
-----------------------------------------------------------------

Nope Gmail is there on purpose
Attachment #8522264 - Flags: review?(mgervasini) → review-
Sorry Callek!

So, this should be it...

Pete
Attachment #8522264 - Attachment is obsolete: true
Attachment #8522274 - Flags: review?(mgervasini)
Comment on attachment 8522274 [details] [diff] [review]
bug1095593_version-control-tools_v3.patch

looks good.
Attachment #8522274 - Flags: review?(mgervasini) → review+
Attachment #8522062 - Flags: checked-in+
Let's first test it, and if all ok, we can close the bug...
Kendall,

Morgan still seems not to have access, is there anything we need to do to activate this change?

Pete



remote: Failed to add the host to the list of known hosts (/home/vagrant/.ssh/known_hosts).
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 0 changes to 0 files (-1 heads)
remote: ** you (mphillips@mozilla.com) are not allowed to push to the production branch
remote: transaction abort!
remote: rollback completed
remote: abort: pretxnchangegroup.b_whitelist hook failed
Flags: needinfo?(klibby)
Yes, you need to ask is to deploy the updated hook. :-)

Updated whitelist_releng.py to 2232e0a9bea3.
Flags: needinfo?(klibby)
Thanks Kendall!
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.