1095604 - Add new "SIM Settings" section.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Jan Keromnes [:janx]]

I think the following items should be separated from the other "Network & Connectivity" items into a new "SIM Settings" section:
- SIM Manager
- Cellular & Data
- Call Settings
- Messaging Settings

Motivations:
- All these items relate to the SIM card(s), the others don't.
- They're all disabled when SIM is disabled or absent.
- "Network & Connectivity" is a big category.
- Place similar items WiFi and Bluetooth next to each other.

Comment 1

[Jan Keromnes [:janx]]

Attachment: gaia pull request

Evelyn, please have a look.

Comment 2

[Jan Keromnes [:janx]]

Attachment: simsettings.png

Comment 3

[Jan Keromnes [:janx]]

Evelyn looks busy. Arthur, do you think you could have a quick look please?

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks for the effort. It looks sane but I'm afraid that I cannot make the call. Jenny, what do you think?

Comment 5

[Jenny Lee]

Hi Jan,
Thanks for the suggestion! I think in a way your proposal makes a lot of sense, but separating the panels you listed from Network & connectivity does not reflect the actual state accurately, ex. "Cellular & data" contains network & connectivity function, "Internet sharing" is heavily SIM related.. 

ni Bruce to comment on this. Hi Bruce, is this something we might want to consider in Settings future release?

Comment 6

[Jan Keromnes [:janx]]

Hi Jenny, thanks for your reply!

Semantically, "SIM Settings" is a sub-group of "Network & Connectivity" with more correlation between elements: the SIM state is in common, and it enables/disables the whole block. "Cellular & data" does control connectivity somewhat, but through the SIM only, and "Internet sharing" is not very SIM-related (most of the time I use it is to share the phone's WiFi connection to my laptop through USB).

Bruce, I look forward to your opinion on this.

Comment 7

[Evelyn Hung]

Comment on attachment 8519037 [details] [review]
gaia pull request

Sorry for my late reply, I was in a business trip. It seems that thing is on-going, so clear my review request.

Comment 8

[Jan Keromnes [:janx]]

Comment on attachment 8519037 [details] [review]
gaia pull request

Hi Evelyn, it looks like this is a sensible change. I'm still waiting for Bruce's opinion on UX, but I'd also appreciate an actual review please.

Comment 9

[Evelyn Hung]

Comment on attachment 8519037 [details] [review]
gaia pull request

redirect to Arthur, since I'm not working on Settings for a while.

On the other hand, I was wondering that if this is a change the UX team can make decision without Product's agreement. Jenny, is this a change bigger than you can manage?

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8519037 [details] [review]
gaia pull request

The patch looks good to me. Please resolve the conflict that might be caused by bug 1092104.

Let's wait for the decision of UX and PM before merging.

Comment 11

[Jenny Lee]

Hi all,

From UX stand point, I wouldn't suggest to make the change for the naming issue mentioned in comment 5. From attachment 8519038 [details], I see that "Cellular & Data" will be a little further down the list, user has to scroll a bit to get to it. This is not preferred because "Cellular & Data" is where user would come back and change setting more often than the other 3 items listed under "SIM settings", I'd like it to be easily found on the list.  

That being said, I do agree that there's need to examine the item order under Network & Connectivity (potentially the entire Settings). Thanks!

Comment 12

[Jan Keromnes [:janx]]

Thanks for your feedback, Jenny!

I had actually replied to your remarks from comment 5 in comment 6, but maybe you didn't see that.

Also, I did put "Cellular & Data" higher up in the SIM items, for the same reasons you mention, but putting Bluetooth, NFC and Internet Sharing above the SIM settings pushes "Cellular & Data" off the screen a bit. I agree this needs to be addressed, so I'll follow up with a better suggestion.

Comment 13

[Jan Keromnes [:janx]]

Attachment: simsettings.png

Hi Jenny, I gave some thought to your feedback and came up with a new version.

Benefits:
- Smaller code change.
- "Cellular & Data" is higher up (can also be moved to "SIM Settings" and still be visible).
- "Bluetooth" is more accessible, and not cut in half weirdly.
- "Wi-Fi" and "Bluetooth" are next to each other.
- Bottom of Flame screen becomes flush with options.

Comment 14

[Jan Keromnes [:janx]]

Attachment: alternative.png

"Cellular & Data" can also be moved to "SIM Settings" if you feel that makes more sense. All listed benefits still hold.

Comment 15

[Jan Keromnes [:janx]]

Comment on attachment 8519037 [details] [review]
gaia pull request

Arthur, in parallel of UX feedback, please have a look at the code change (it is quite small).

Comment 16

[Arthur Chen [:arthurcc][inactive after 6/30]]

The code looks good. Let's wait for Jenny's feedback.

Comment 17

[Jenny Lee]

Comment on attachment 8568626 [details]
simsettings.png

Hello Jan,

I would further split the current "Cellular & Data" panel into two separate panels: Data connection and roaming toggles as one and stays in the Network & Connectivity section, the remaining "SIM settings" part as another that will be moved to new SIM settings section you proposed. 

But I really wouldn't suggest making the change at this stage, as v3 direction is still unclear. We may not have the same Settings structure. Thanks for understanding!

Comment 18

[Jan Keromnes [:janx]]

Thanks for the UX feedback Jenny! I agree that the Settings app really needs a global overhaul, with most options rearranged and some panels being split or merged.

However, this is just a tiny change with a definite tiny improvement. Maybe it doesn't make sense to involve UX for such an small change (moving a few options not very far).

Arthur, I'd like to land this very small short-term improvement without blocking on Settings app's complete redesign for v3, do you think that's possible?

Comment 19

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8519037 [details] [review]
gaia pull request

Thanks for the patch, but this is definitely a UX decision. If Jenny already had a plan on this (comment 17), maybe we should implement it in this patch.

Comment 20

[BMO Automation]

Firefox OS is not being worked on