Closed Bug 1095633 Opened 5 years ago Closed 5 years ago

get rid of HAVE_CPP_TROUBLE_COMPARING_TO_ZERO

Categories

(Core :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(2 files)

None of our current compilers across our tier-1 platforms have any trouble.  I'm guessing anything that *does* have trouble probably falls over in other places.
Inspecting mozilla-config.h says this is never used, and try seems to agree:

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=4f10c3b4a503

I guess...bz...is the best person to review?
Attachment #8519168 - Flags: review?(bzbarsky)
One less configure check is a good thing.
Attachment #8519169 - Flags: review?(mshal)
Comment on attachment 8519168 [details] [diff] [review]
part 1 - remove uses of HAVE_CPP_TROUBLE_COMPARING_TO_ZERO from headers

r=me
Attachment #8519168 - Flags: review?(bzbarsky) → review+
Attachment #8519169 - Flags: review?(mshal) → review+
https://hg.mozilla.org/mozilla-central/rev/1d3fe1e87f99
https://hg.mozilla.org/mozilla-central/rev/48732e40875a
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.