1095643 - Show site identity when mixed content is blocked

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Margaret Leibovic]

I think this is a regression from bug 966866 (or really from bug 945212, but we didn't handle fixing this correctly).

I believe we should still show the site identity information when mixed content is *blocked*, since in that case all the content on the page is in fact coming from the verified domain.

Comment 1

[:Margaret Leibovic]

Attachment: Only hide site identity info if mixed content is loaded

I'm fixing the regression here by making sure we show site identity information if mixed content is blocked. However, I filed bug 1102539 as a follow-up to come up with a better solution here that would allow us to always show the site identity information.

Comment 2

[:Margaret Leibovic]

Comment on attachment 8526378 [details] [diff] [review]
Only hide site identity info if mixed content is loaded

Review of attachment 8526378 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/toolbar/SiteIdentityPopup.java
@@ +96,2 @@
>          final MixedMode mixedMode = siteIdentity.getMixedMode();
> +        if (mixedMode == MixedMode.MIXED_CONTENT_LOADED) {

After looking into some potential solutions for bug 1102539, I'm tempted to just remove all of this logic and always show the site identity data, since we will be showing the "unknown identity" in the case of loaded mixed content. While "unknown" isn't exactly true in this case, it prevents the user from thinking they're on a secure page when they're not.

And if we always show this "unknown identity" here, we'll avoid the weird UI issue of the darker notification with no light information above it.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to :Margaret Leibovic from comment #2)

> After looking into some potential solutions for bug 1102539, I'm tempted to
> just remove all of this logic and always show the site identity data, since
> we will be showing the "unknown identity" in the case of loaded mixed
> content. While "unknown" isn't exactly true in this case, it prevents the
> user from thinking they're on a secure page when they're not.
> 
> And if we always show this "unknown identity" here, we'll avoid the weird UI
> issue of the darker notification with no light information above it.

Sounds like a good idea to me. Let's live with it and see how it feels. I think it will help us get a forward direction.

Comment 4

[:Margaret Leibovic]

Attachment: Always show site identity info

Changing the approach here based on previous comments.

Comment 5

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/b1fe09f763e2

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b1fe09f763e2