[demos] White-list additional files for #Fx10 demos

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: groovecoder, Assigned: jezdez)

Tracking

Details

(Reporter)

Description

4 years ago
hoosteeno, davidwalsh: Hey guys sorry to bug you again, moved on to the second demo
13:25 mbest:
ZIP file contains an unacceptable file: Compressed/fileloader.jsgz
13:25 davidwalsh:
wtf
13:26 mbest:
So that's a gzip file of the fileloader.js
13:26 davidwalsh:
OK, I see we have a blacklist
13:26 mbest:
Yeah, seems to block gzip.
13:26 mbest:
and in this case, they make use of it on their own when availalbe.
13:27 davidwalsh:
I see "'application/x-gzip'," in the list
13:27 groovecoder:
mbest: what's ".jsgz" ?
13:28 groovecoder:
gzipped js?
13:28 davidwalsh:
groovecoder: ubernostrum: jezdez:  Can someone make a quick PR to allow that, let him upload, and then revert the commit?
13:28 mbest:
Yes
13:28 groovecoder:
davidwalsh: mbest: I'll start it ...
13:29 jezdez:
jsgz 0_0
13:29 davidwalsh:
Looks like we also have application-zip too
13:29 davidwalsh:
May want to allow that, just for giggles
13:29
ChanServ has changed mode: +o mars
13:30 mbest:
Thanks all, sorry to be odd.
13:30 mbest:
New ground and all that.
13:30 jezdez:
yeah, no worries :)
13:30 jezdez:
glad someone gets to use our software and battle tests it :)
13:31 jezdez:
should we allow cssgz as well?
13:31 mbest:
So there will be a bunch of very strange names, let me see if I can get you the full list
(Reporter)

Comment 1

4 years ago
The full list of allowed file-names should be: *.jsgz, *datagz, *memgz

Comment 2

4 years ago
*.jsgz, *datagz, *memgz
(Assignee)

Updated

4 years ago
Assignee: nobody → jezdez
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED

Comment 4

4 years ago
Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/edba14ed4006b4c02c9fa17d87b90e6f3bf0a99b
fix bug 1095649 - added blacklist override constance value to temporarily allow uploading files that are are matched by an ambiguous mimetype like application/gzip

https://github.com/mozilla/kuma/commit/1dc8e4b41c3a128a6437cb73c50f20c0ddf28d11
Merge pull request #2902 from jezdez/bug1095649

fix bug 1095649 - added blacklist override constance value to temporarily allow uploading files that are are matched by an ambiguous mimetype like application/gzip

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Comment 5

4 years ago
Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/9403b7ced708dfef15bef33309ca90b06773d6ba
bug 1095649 - fixed a typo in the test added in edba14ed4006b4c02c9fa17d87b90e6f3bf0a99b

https://github.com/mozilla/kuma/commit/9a855539a8be0462cc32350c26d5c2de01f3242e
Merge pull request #2903 from jezdez/bug1095649-2

bug 1095649 - fixed a typo in the test added in edba14ed4006b4c02c9fa17d87b90e6f3bf0a99b
You need to log in before you can comment on or make changes to this bug.