1095691 - aws_manage_securitygroups deletes the wrong rules

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

tests - Delete rule ('inbound', u'icmp', u'-1', u'-1') to set([u'10.22.248.0/22', u'10.22.75.6/31', u'10.22.252.0/22', u'10.26.48.25/32', u'10.26.48.17/32', u'10.26.48.16/32', u'10.26.48.23/32', u'10.26.48.43/32']) (y/N) y

2014-11-07 12:03:36,376 - tests - removing rule for ('inbound', u'icmp', u'-1', u'-1') to set(['10.22.240.0/20'])

which was a rule it just added, actually.  Thankfully this didn't cause too much mayhem.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

15:05 <@catlee> the logging is wrong I think
15:05 <@catlee> yeah
15:05 <@catlee>             log.info("%s - removing rule for %s to %s", remote_sg.name,
15:05 <@catlee>                      rule_key, new_hosts)
15:05 <@catlee> should be old_hosts there
15:06 <@catlee> since that's what it asks you about, and what it actually deletes

that'd be a relief, but I *think* I saw differently?

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: bug1095691-fix-print.patch

Comment 3

[:kanban-engops]

Dustin J. Mitchell changed story state to finished in Pivotal Tracker

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8524004 [details] [diff] [review]
bug1095691-fix-print.patch

https://hg.mozilla.org/build/cloud-tools/rev/7e710c7bf646