aws_manage_securitygroups deletes the wrong rules

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: dustin, Assigned: dustin)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

tests - Delete rule ('inbound', u'icmp', u'-1', u'-1') to set([u'10.22.248.0/22', u'10.22.75.6/31', u'10.22.252.0/22', u'10.26.48.25/32', u'10.26.48.17/32', u'10.26.48.16/32', u'10.26.48.23/32', u'10.26.48.43/32']) (y/N) y

2014-11-07 12:03:36,376 - tests - removing rule for ('inbound', u'icmp', u'-1', u'-1') to set(['10.22.240.0/20'])

which was a rule it just added, actually.  Thankfully this didn't cause too much mayhem.
15:05 <@catlee> the logging is wrong I think
15:05 <@catlee> yeah
15:05 <@catlee>             log.info("%s - removing rule for %s to %s", remote_sg.name,
15:05 <@catlee>                      rule_key, new_hosts)
15:05 <@catlee> should be old_hosts there
15:06 <@catlee> since that's what it asks you about, and what it actually deletes

that'd be a relief, but I *think* I saw differently?
Created attachment 8524004 [details] [diff] [review]
bug1095691-fix-print.patch
Attachment #8524004 - Flags: review?(rail)

Comment 3

4 years ago
Dustin J. Mitchell changed story state to finished in Pivotal Tracker
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Updated

4 years ago
Attachment #8524004 - Flags: review?(rail) → review+
Component: Tools → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.