1095750 - Make Docker use TLS_v1 protocol for TLSConfig

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

I was hitting an error when trying to hack on MozReview, looking like this:

requests.exceptions.SSLError: [Errno 1] _ssl.c:504: error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version

A quick search got me here:

https://github.com/docker/docker-py/issues/364

Which suggests setting the ssl_version to TLS_v1 for the handshake. Doing that locally got rid of the problem for me, and I was successfully able to create a test instance of the MozReview infrastructure after that.

Comment 1

[Gregory Szorc [:gps]]

We should use TLS over SSLv23 anyway since it is the newer protocol. As long as clients and server support TLS, this should be a no-brainer.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: MozReview Request: bz://1095750/mconley

Comment 3

[Mike Conley (:mconley) (:⚙️)]

/r/227 - Bug 1095750 - vcttesting: Make Docker use TLS_v1 protocol for TLSConfig. r=?

Pull down this commit:

hg pull review -r e96db8d4d1fd8b3c36077ae7347b5ff81997e4fe

Comment 4

[Gregory Szorc [:gps]]

https://reviewboard.mozilla.org/r/225/#review113

Ship It!

Comment 5

[Mike Conley (:mconley) (:⚙️)]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/dbdcef8198e9

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Attachment: MozReview Request: Bug 1095750 - vcttesting: Make Docker use TLS_v1 protocol for TLSConfig. r=?