Fixup Windows focus routing in the PluginInstances for e10s

RESOLVED FIXED in Firefox 38

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jimm, Assigned: jimm)

Tracking

(Blocks 1 bug)

Trunk
mozilla38
All
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(e10sm5+, firefox38 fixed)

Details

Attachments

(2 attachments, 2 obsolete attachments)

Posted file dom focus test case (obsolete) —
Follow up for part 9 in bug 669200. We track focus changes in PluginInstanceChild and relay those to the parent via PluginInstanceParent. Currently we do this hack where we post a native event down to win widget to accomplish this on the chrome side. 

This doesn't work with e10 since PluginInstanceParent exists in content, so we need a work around. Wondering if a simple simulated click via dom window utils on the plugin puppet widget would fix this. SetFocus on PuppetWidget is currently a no-op, so I'm not sure. Need to do some testing.
Blocks: 1095930
Assignee: nobody → jmathies
Posted patch patch (obsolete) — Splinter Review
Comment on attachment 8563538 [details] [diff] [review]
patch

This rips out an old fix I wrote like five years ago for oopp, and replaces it with something that is much less hackish and works with both e10s and non-e10s.
Attachment #8563538 - Flags: review?(benjamin)
Posted file dom focus test case
Simpler test case with just the test plugin.
Attachment #8519238 - Attachment is obsolete: true
Attachment #8563580 - Attachment is patch: false
Attachment #8563580 - Attachment mime type: text/plain → text/html
Blocks: e10s-plugins
Comment on attachment 8563538 [details] [diff] [review]
patch

I'm not going to be able to review this; bouncing to aklotz.
Attachment #8563538 - Flags: review?(benjamin) → review?(aklotz)
Comment on attachment 8563538 [details] [diff] [review]
patch

Review of attachment 8563538 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/windows/nsWindow.cpp
@@ -250,5 @@
>  
>  TriStateBool nsWindow::sHasBogusPopupsDropShadowOnMultiMonitor = TRI_UNKNOWN;
>  
> -// Used in OOPP plugin focus processing.
> -const wchar_t* kOOPPPluginFocusEventId   = L"OOPP Plugin Focus Widget Event";

Nit: static linkage for kOOPPPluginFocusEventId?
Attachment #8563538 - Flags: review?(aklotz) → review+
Attachment #8563538 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ae8e1af090f6
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.