1095761 - Fixup Windows focus routing in the PluginInstances for e10s

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Jim Mathies [:jimm]]

Attachment: dom focus test case

Follow up for part 9 in bug 669200. We track focus changes in PluginInstanceChild and relay those to the parent via PluginInstanceParent. Currently we do this hack where we post a native event down to win widget to accomplish this on the chrome side. 

This doesn't work with e10 since PluginInstanceParent exists in content, so we need a work around. Wondering if a simple simulated click via dom window utils on the plugin puppet widget would fix this. SetFocus on PuppetWidget is currently a no-op, so I'm not sure. Need to do some testing.

Comment 1

[Jim Mathies [:jimm]]

Attachment: patch

Comment 2

[Jim Mathies [:jimm]]

Comment on attachment 8563538 [details] [diff] [review]
patch

This rips out an old fix I wrote like five years ago for oopp, and replaces it with something that is much less hackish and works with both e10s and non-e10s.

Comment 3

[Jim Mathies [:jimm]]

Attachment: dom focus test case

Simpler test case with just the test plugin.

Comment 4

[Jim Mathies [:jimm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d5f00690b84e

Comment 5

[Benjamin Smedberg]

Comment on attachment 8563538 [details] [diff] [review]
patch

I'm not going to be able to review this; bouncing to aklotz.

Comment 6

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8563538 [details] [diff] [review]
patch

Review of attachment 8563538 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/windows/nsWindow.cpp
@@ -250,5 @@
>  
>  TriStateBool nsWindow::sHasBogusPopupsDropShadowOnMultiMonitor = TRI_UNKNOWN;
>  
> -// Used in OOPP plugin focus processing.
> -const wchar_t* kOOPPPluginFocusEventId   = L"OOPP Plugin Focus Widget Event";

Nit: static linkage for kOOPPPluginFocusEventId?

Comment 7

[Jim Mathies [:jimm]]

Attachment: patch (r=aklotz)

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ae8e1af090f6

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ae8e1af090f6