1095775 - Show compatibility error if an add-on uses createStorage

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Compatibility Tools, defect)

Description

[Jorge Villalobos [:jorgev] (he/him)]

As explained in bug 660237, there have been some changes in the nsIDOMStorage API. The createStorage function now also takes a window as an additional argument. All instances of this function need to be flagged.

This is a compatibility error, so the add-on shouldn't be upgraded in this case. It should also appear as a warning in regular validations.

Message:

The createStorage function in nsIDOMStorage now expects a window as its first argument. See <LINK> for more information.

Link: https://bugzilla.mozilla.org/show_bug.cgi?id=660237#c43

Affected add-on:

https://addons.mozilla.org/addon/galaxytoolbar/

Release timing:

The next Firefox release will happen on November 25th. Ideally we should run the compat bump before Nov 19th.

Comment 1

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/amo-validator/pull/257

Comment 2

[Mark Striemer [:mstriemer]]

https://github.com/mstriemer/amo-validator/commit/20a6cdc790229dbf37a004543afeb5472e322590

Comment 3

[Victor Carciu]

Verified as fixed : http://screencast.com/t/Vy5rMQGR3cm7