Closed
Bug 1095795
Opened 10 years ago
Closed 7 years ago
Replace tabCurve overrides in devedition.inc.css with CSS variables
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: bgrins, Assigned: bgrins)
References
Details
Attachments
(2 files)
|
2.32 KB,
patch
|
MattN
:
review+
|
Details | Diff | Splinter Review |
|
5.25 KB,
patch
|
Details | Diff | Splinter Review |
Once Bug 1091001 lands this will make it easy to clean up some of the tab overriding in the devedition css file. This will also give us access to changing tabToolbarNavbarOverlap, which when set to 0 should make the behavior between the tabs and navbar more consistent with the default theme.
|
Assignee | |
Comment 1•9 years ago
|
||
This is the CSS cleanup that is possible once Bug 1122726 lands and tab-curve-width / tab-curve-half-width are CSS variables
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8554892 [details] [diff] [review] tab-curve-devedition.patch Review of attachment 8554892 [details] [diff] [review]: ----------------------------------------------------------------- LGTM (without testing it)
Attachment #8554892 -
Flags: review?(MattN+bmo) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Rebased
|
|
Assignee | |
Comment 4•7 years ago
|
||
These changes aren't needed anymore with the Photon styles
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•