DevEdition: Hovering over the default theme will show the Australis theme instead of the DevEdition theme

RESOLVED WORKSFORME

Status

()

RESOLVED WORKSFORME
4 years ago
3 years ago

People

(Reporter: jaws, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

STR:
Enter customize mode
Hover over a lightweight theme
Hover over the default theme
See how default reverts back to DevEdition theme
Select a lightweight theme
Hover over the default theme

ER:
The preview shows the DevEdition theme

AR:
The preview shows shows Australis
Clicking on Default will switch it to DevEdition though
I believe this was an issue even before 1093368 based on the build from here: https://tbpl.mozilla.org/?tree=Gum&rev=21d7014b7614 before it landed.

It's probably because the lightweightThemeSelected variable will always be true in this case: http://dxr.mozilla.org/mozilla-central/source/browser/base/content/browser-devedition.js#65.  I guess we could pass an argument to _updateStyleSheetFromPrefs that will tell it to ignore whether a lw theme is selected.

Although I really think we should push forward with a plan to make this an actual lw theme so that shows up in the list and doesn't have these edge cases like I said in: https://bugzilla.mozilla.org/show_bug.cgi?id=1094821#c1.

Comment 2

3 years ago
I'm pretty sure this works now that this is a lightweight theme.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.