Closed
Bug 1095827
Opened 10 years ago
Closed 10 years ago
[Developer Edition] navigation toolbar too wide in customize mode
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
Firefox 36
People
(Reporter: soeren.hentzschel, Assigned: bgrins)
Details
(Whiteboard: [devedition-polish])
Attachments
(2 files)
537.57 KB,
image/png
|
Details | |
1008 bytes,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
It looks like the navigation toolbar is a few pixels too wide in the customize mode, please see the highlighted area in the screenshot and compare with the light theme. OS X 10.10, HiDPI.
Reporter | ||
Updated•10 years ago
|
Whiteboard: [devedition-polish]
Assignee | ||
Comment 1•10 years ago
|
||
I think it's the border on #customization-container combined with the fact that we have no border on #nav-bar that's causing that effect - I see it on linux also. We could either remove the border: none on nav-bar or add a border: none to the customization container.
Assignee | ||
Comment 2•10 years ago
|
||
I'm not actually sure if this is the right approach here. We could alternatively make the border options for customize mode variables, although they do get pretty complicated (http://dxr.mozilla.org/mozilla-central/source/browser/themes/linux/browser.css#2196-2206).
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attachment #8524142 -
Flags: review?(gijskruitbosch+bugs)
Comment 3•10 years ago
|
||
Comment on attachment 8524142 [details] [diff] [review] customize-border.patch Review of attachment 8524142 [details] [diff] [review]: ----------------------------------------------------------------- Apologies for the delay; yes, I think this is neater than variable-ifying this.
Attachment #8524142 -
Flags: review?(gijskruitbosch+bugs) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/419509456af4
Keywords: checkin-needed
Whiteboard: [devedition-polish] → [fixed-in-fx-team][devedition-polish]
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/419509456af4
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team][devedition-polish] → [devedition-polish]
Target Milestone: --- → Firefox 36
You need to log in
before you can comment on or make changes to this bug.
Description
•