1095827 - [Developer Edition] navigation toolbar too wide in customize mode

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Sören Hentzschel]

Attachment: screenshot

It looks like the navigation toolbar is a few pixels too wide in the customize mode, please see the highlighted area in the screenshot and compare with the light theme.

OS X 10.10, HiDPI.

Comment 1

[Brian Grinstead [:bgrins]]

I think it's the border on #customization-container combined with the fact that we have no border on #nav-bar that's causing that effect - I see it on linux also.

We could either remove the border: none on nav-bar or add a border: none to the customization container.

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: customize-border.patch

I'm not actually sure if this is the right approach here.  We could alternatively make the border options for customize mode variables, although they do get pretty complicated (http://dxr.mozilla.org/mozilla-central/source/browser/themes/linux/browser.css#2196-2206).

Comment 3

[:Gijs (he/him)]

Comment on attachment 8524142 [details] [diff] [review]
customize-border.patch

Review of attachment 8524142 [details] [diff] [review]:
-----------------------------------------------------------------

Apologies for the delay; yes, I think this is neater than variable-ifying this.

Comment 4

[Brian Grinstead [:bgrins]]

https://hg.mozilla.org/integration/fx-team/rev/419509456af4

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/419509456af4