If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[System] The fake-notifications width is not updated in Utility tray

VERIFIED FIXED

Status

Firefox OS
Gaia::System
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: sasikala, Assigned: etienne)

Tracking

(Blocks: 1 bug)

unspecified
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:2.0M+, b2g-v2.0 wontfix, b2g-v2.0M verified, b2g-v2.1 unaffected, b2g-v2.1S unaffected, b2g-v2.2 unaffected, b2g-master unaffected)

Details

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
1. Title: Fake-notifications width is not updated in Utility tray
2. Precondition: Should have some notification(either screenshots/messages)
3. Tester's Action: 
    Scenario 1)
        1.Receive Bluetooth request -> accept the request
        2.Once the file receiving is done
        3.The width which is shown for Review request is still shown 
        4.The space is updated only after pull up the utility tray
    Scenario 2)
        1.Have some screenshot/messages
        2.Open the music app -> the widget will be shown in the notification container
        3.Click on the widget and move up -> the widget notification is  removed even when the music is playing
4. Actual Symptom (ENG.) : The space is still shown even after the transfer request is done and the widget is removed in case of music
5. Expected: In scenario 1) the space should not be shown once the transfer request is done
In scenario 2) the widget should not be removed when music is still playing
(Reporter)

Comment 1

3 years ago
Hi Etienne,

1.This issue doesn't exist before the patch https://bugzilla.mozilla.org/show_bug.cgi?id=1073807
2.Previously we are not able to move the fake-nofications container but now we can scroll the fake notifications and when moving the notifications are removed(which is the issue reported in scenario 2) which is due to that scrolling effect
     a) We can fix the scenario 2) by making overflow: hidden(removing - overflow-y: scroll;overflow-x: hidden;)in https://github.com/mozilla-b2g/gaia/blob/v2.0/apps/system/style/notifications/notifications.css#L137 => but not sure this will cause any side affect
3) Not sure about how to handle the scenario 1)

Note: This is 2.0 only issue. Will you please have a look at this issue?

Thanks,
Sasikala
Flags: needinfo?(etienne)
Sasikala, can you attach a screenshot demonstrating the issue?
Flags: needinfo?(sasikala.paruchuri8)
(Assignee)

Updated

3 years ago
Assignee: nobody → etienne
Flags: needinfo?(etienne)
(Assignee)

Comment 3

3 years ago
Created attachment 8522981 [details] [review]
Gaia PR

Interesting. Basically the div in the utility tray becomes scrollable because it contains a full height desktop-notifications-placeholder + the fake notifications. But obviously when you scroll it it doesn't scroll the absolutely positioned, outside of the utility tray dom, desktop-notification-container.

Moving all notifications (desktop + the fake ones) outside of the utility tray dom makes for a big diff, but it's actually a simple patch and I think it's the safest solution.

I also think we should block on this, STR:
- have a lot of real notifications (by taking screenshots)
- have a fake notification, playing a track in the music app is a good way to do this
- open the utility tray
- drag the playback controls from the music app up

Expected:
- it should scroll all notifications, fake and real

Actual:
- you can loose the playback by dragging them off-screen while the screenshot notifications are not moving.
Attachment #8522981 - Flags: review?(chrislord.net)

Comment 4

3 years ago
Comment on attachment 8522981 [details] [review]
Gaia PR

So this looks good to me, but I think Vivien is the best person to review this now and will have a better idea if there are any implications for doing this (if this needs to be fixed quickly, or you think I'm being over-cautious, feel free to redirect this back to me though)
Attachment #8522981 - Flags: review?(chrislord.net) → review?(21)
(Reporter)

Comment 5

3 years ago
Etienne is already checking the issue and given a patch for same. Clearing ni
Flags: needinfo?(sasikala.paruchuri8)
(Reporter)

Comment 6

3 years ago
Hi Viven,
Will you please review the patch from Etienne.
Thanks!
Flags: needinfo?(21)
(Assignee)

Comment 7

3 years ago
Comment on attachment 8522981 [details] [review]
Gaia PR

Don't know if there's still traction for this patch, but if so you'll probably be the reviewer :)
Attachment #8522981 - Flags: review?(21) → review?(chrislord.net)

Comment 8

3 years ago
Comment on attachment 8522981 [details] [review]
Gaia PR

I'm going to trust what I said before (and from looking again) - this looks good to me. I think landing it and testing it for a day or two before uplifting would be sensible though.
Attachment #8522981 - Flags: review?(chrislord.net) → review+
(Assignee)

Updated

3 years ago
status-b2g-v2.0: --- → affected
status-b2g-v2.0M: --- → unaffected
status-b2g-v2.1: --- → unaffected
status-b2g-v2.2: --- → unaffected

Updated

3 years ago
Duplicate of this bug: 1110664

Updated

3 years ago
Blocks: 1054172, 1080481
blocking-b2g: --- → 2.0M+
status-b2g-v2.0M: unaffected → affected

Comment 10

3 years ago
HI Kai-Zhen,
2.0M+, Thanks!
Flags: needinfo?(kli)
v2.0m: https://github.com/mozilla-b2g/gaia/commit/09b8808bcfa690f2ace7a2a4366e2736e8dd70cb
status-b2g-v2.0M: affected → fixed
Flags: needinfo?(kli)
Keywords: verifyme
This bug has been successfully verified on Woodduck v2.0.
See attachment: verified_v2.0m.mp4,
Reproduce rate: 0/5

STR:
1.Have some screenshot/messages.
2.Receive a Bluetooth request -> tap on Transfer button to accept the request.
3.Once the file receiving is done.
**The request message disappears from notifications bar and the number of notifications is updated normally.
4.Tap on "File received" to view this sharing file.
**"File received" message disappears from notifications bar and the number of notifications is updated normally.

5.Open the Music app -> the widget will be shown in the notification container.
6.Click on the widget and move up
**The music widget can't be removed.

Woodduck 2.0 build:
Gaia-Rev        688e86b46229e3281beb22fd29f723724eda9df5
Gecko-Rev       bb95bcf5c2033a59b3261b93804151d1addb75eb
Build-ID        20141230050313
Version         32.0
Device-Name     jrdhz72_w_ff
FW-Release      4.4.2
FW-Incremental  1419887136
FW-Date         Tue Dec 30 05:05:59 CST 2014
status-b2g-v2.0M: fixed → verified
Created attachment 8542449 [details]
verified_2.0m.MP4
Keywords: verifyme

Comment 14

3 years ago
Hi Etienne,
Do you like to raise approval request for V2.0? Thanks!
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(21) → needinfo?(etienne)
(Assignee)

Comment 15

3 years ago
(In reply to Josh Cheng [:josh] from comment #14)
> Hi Etienne,
> Do you like to raise approval request for V2.0? Thanks!

If it's 2.0+ I'll happily do it, otherwise I'm fine with this being a 2.0m-only patch.
Flags: needinfo?(etienne)

Comment 16

3 years ago
Hi Etienne,
I think we can just land this patch on 2.0M since it's not regression. Thanks!
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-b2g-v2.0: affected → wontfix
status-b2g-v2.1S: --- → unaffected
status-b2g-master: --- → unaffected
Resolution: --- → FIXED

Updated

3 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.