Closed
Bug 1095882
Opened 10 years ago
Closed 10 years ago
Suppress MSVC warnings in third-party code: toolkit/components/protobuf
Categories
(Toolkit :: General, defect)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: cpeterson, Assigned: cpeterson)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
882 bytes,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
We already suppress some gcc/clang and MSVC warnings in the third-party protobuf code, but we were missing some MSVC warnings:
> toolkit\components\protobuf\google/protobuf/io/zero_copy_stream_impl_lite.cc(159) : warning C4018: '<' : signed/unsigned mismatch
> toolkit\components\protobuf\google/protobuf/io/zero_copy_stream_impl_lite.cc(179) : warning C4018: '<=' : signed/unsigned mismatch
> toolkit\components\protobuf\google/protobuf/stubs/common.cc(355) : warning C4018: '<' : signed/unsigned mismatch
> toolkit\components\protobuf\google/protobuf/stubs/common.cc(40) : warning C4005: 'WIN32_LEAN_AND_MEAN' : macro redefinition
Attachment #8519395 -
Flags: review?(dtownsend+bugmail)
|
||
Updated•10 years ago
|
Attachment #8519395 -
Flags: review?(dtownsend+bugmail) → review+
|
Assignee | |
Comment 1•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/cbad3170d69c
|
||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cbad3170d69c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•