1095902 - logsSaving string have two extra 'COMBINING DOT BELOW' (U+0323)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[YF (Yang)]

https://github.com/mozilla-b2g/gaia/commit/aede8cf5519b91d11869ff07e7c23eb55959e94e#diff-81fe86f3f20787d354c9275a837572b9R248

Comment 1

[YF (Yang)]

Attachment: patch

No unexpected characters appear in other languages, so I did not change the entitle, base by http://transvision.mozfr.org/string/?entity=apps/system/system.properties:logsSaving&repo=gaia.

Comment 2

[:gerard-majax]

Do you mind to explain ?

Comment 3

[YF (Yang)]

Do you see a dot at the 's' below?
Using an advanced text editor or Hex editor, you can see the two extra characters as the summary.

Comment 4

[:gerard-majax]

Ok, it's because there is an invalid unicode char that got inside the string, with two small dots. I'm sorry, this is nearly invisible in my browser ...

I'm no system peer, however.

Comment 5

[:gerard-majax]

(In reply to YF (Yang) from comment #3)
> Do you see a dot at the 's' below?
> Using an advanced text editor or Hex editor, you can see the two extra
> characters as the summary.

yes, that is barely visible and indeed it looks like the rest of the dust on my laptop's screen :)

Comment 6

[:gerard-majax]

Comment on attachment 8521457 [details] [review]
patch

That looks good but I'm not a system peer.

Comment 7

[Francesco Lodolo [:flod]]

Change looks good to me, no need to use a new ID since it's clear what the original string should have been.
But this should receive a formal r+ from a module owner/peer.

Comment 8

[YF (Yang)]

I'm sorry because I am wrong read f+ as r+ on bug 1093093.

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8521457 [details] [review]
patch

Thank you!

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/a311055b56e283faa8ac7fa9a179f72a391b5a56