Improve chat input box styling for OS X

RESOLVED FIXED in Thunderbird 36.0

Status

Thunderbird
Instant Messaging
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: aleth, Assigned: aleth)

Tracking

Trunk
Thunderbird 36.0
Bug Flags:
in-testsuite -

Thunderbird Tracking Flags

(thunderbird36 fixed)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

3 years ago
In particular, the border doesn't turn red when the user goes over the character limit, and there is an apparent gap in the top border of the input box.
(Assignee)

Comment 1

3 years ago
Created attachment 8519434 [details] [diff] [review]
tbinputbox.diff
Attachment #8519434 - Flags: ui-review?(richard.marti)
(Assignee)

Comment 2

3 years ago
Created attachment 8519435 [details]
Screen Shot with patch
Comment on attachment 8519434 [details] [diff] [review]
tbinputbox.diff

ui-r+ depending on the screenshot. Have you tried how it looks when the red would have the same transparency as the focused state? For me the red looks a little bit pale.
Attachment #8519434 - Flags: ui-review?(richard.marti) → ui-review+
(Assignee)

Comment 4

3 years ago
Created attachment 8519438 [details] [diff] [review]
tbinputbox.diff v2

Good idea. I also noticed the character counter needed tweaking, as on OSX there is also a (blue) border when we are not over the limit, and the position was a pixel off.
Attachment #8519434 - Attachment is obsolete: true
Attachment #8519438 - Flags: ui-review?(richard.marti)
(Assignee)

Comment 5

3 years ago
Created attachment 8519439 [details]
Screen shot with patch v2
Attachment #8519435 - Attachment is obsolete: true
Comment on attachment 8519438 [details] [diff] [review]
tbinputbox.diff v2

This looks better and also the counter position is better.
Attachment #8519438 - Flags: ui-review?(richard.marti) → ui-review+
(Assignee)

Updated

3 years ago
Attachment #8519438 - Flags: review?(clokep)
Attachment #8519438 - Flags: review?(clokep) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
(Assignee)

Comment 7

3 years ago
https://hg.mozilla.org/comm-central/rev/ff5659f262bc
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 36.0
status-thunderbird36: --- → fixed
(Assignee)

Updated

3 years ago
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.