Closed Bug 1095918 Opened 8 years ago Closed 8 years ago

Improve chat input box styling for OS X

Categories

(Thunderbird :: Instant Messaging, defect)

defect
Not set
normal

Tracking

(thunderbird36 fixed)

RESOLVED FIXED
Thunderbird 36.0
Tracking Status
thunderbird36 --- fixed

People

(Reporter: aleth, Assigned: aleth)

References

Details

Attachments

(2 files, 2 obsolete files)

In particular, the border doesn't turn red when the user goes over the character limit, and there is an apparent gap in the top border of the input box.
Attached patch tbinputbox.diff (obsolete) — Splinter Review
Attachment #8519434 - Flags: ui-review?(richard.marti)
Attached image Screen Shot with patch (obsolete) —
Comment on attachment 8519434 [details] [diff] [review]
tbinputbox.diff

ui-r+ depending on the screenshot. Have you tried how it looks when the red would have the same transparency as the focused state? For me the red looks a little bit pale.
Attachment #8519434 - Flags: ui-review?(richard.marti) → ui-review+
Good idea. I also noticed the character counter needed tweaking, as on OSX there is also a (blue) border when we are not over the limit, and the position was a pixel off.
Attachment #8519434 - Attachment is obsolete: true
Attachment #8519438 - Flags: ui-review?(richard.marti)
Attachment #8519435 - Attachment is obsolete: true
Comment on attachment 8519438 [details] [diff] [review]
tbinputbox.diff v2

This looks better and also the counter position is better.
Attachment #8519438 - Flags: ui-review?(richard.marti) → ui-review+
Attachment #8519438 - Flags: review?(clokep)
Attachment #8519438 - Flags: review?(clokep) → review+
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 36.0
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.