1095918 - Improve chat input box styling for OS X

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[aleth [:aleth]]

In particular, the border doesn't turn red when the user goes over the character limit, and there is an apparent gap in the top border of the input box.

Comment 1

[aleth [:aleth]]

Attachment: tbinputbox.diff

Comment 2

[aleth [:aleth]]

Attachment: Screen Shot with patch

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 8519434 [details] [diff] [review]
tbinputbox.diff

ui-r+ depending on the screenshot. Have you tried how it looks when the red would have the same transparency as the focused state? For me the red looks a little bit pale.

Comment 4

[aleth [:aleth]]

Attachment: tbinputbox.diff v2

Good idea. I also noticed the character counter needed tweaking, as on OSX there is also a (blue) border when we are not over the limit, and the position was a pixel off.

Comment 5

[aleth [:aleth]]

Attachment: Screen shot with patch v2

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 8519438 [details] [diff] [review]
tbinputbox.diff v2

This looks better and also the counter position is better.

Comment 7

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/ff5659f262bc