1095926 - Fix -Wcomment warning in OCSP test and mark some OCSP tests as FAIL_ON_WARNINGS

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: fix-Wcomment-warning.patch

The following -Wcomment warning in OCSP test code complains about a C++ comment's command line example containing a Bash backslash line-continuation character, which is unintentionally interpreted by the C preprocessor. This patch merges the two lines, which now exceeds 80 columns, but it does unify the command line example and make it easier to copy/paste as one line.

If you don't like that change, I can simply not mark that directory, (security/manager/ssl/tests/unit/tlsserver/lib) as FAIL_ON_WARNINGS or I could suppress that warning in that directory's moz.build.

security/manager/ssl/tests/unit/tlsserver/lib/OCSPCommon.cpp:174:5 [-Wcomment] multi-line comment

Comment 1

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7861642096c0

Comment 2

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7861642096c0