Fix -Wcomment warning in OCSP test and mark some OCSP tests as FAIL_ON_WARNINGS

RESOLVED FIXED in mozilla36

Status

()

Core
Security: PSM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

(Blocks: 1 bug)

unspecified
mozilla36
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8519451 [details] [diff] [review]
fix-Wcomment-warning.patch

The following -Wcomment warning in OCSP test code complains about a C++ comment's command line example containing a Bash backslash line-continuation character, which is unintentionally interpreted by the C preprocessor. This patch merges the two lines, which now exceeds 80 columns, but it does unify the command line example and make it easier to copy/paste as one line.

If you don't like that change, I can simply not mark that directory, (security/manager/ssl/tests/unit/tlsserver/lib) as FAIL_ON_WARNINGS or I could suppress that warning in that directory's moz.build.

security/manager/ssl/tests/unit/tlsserver/lib/OCSPCommon.cpp:174:5 [-Wcomment] multi-line comment
Attachment #8519451 - Flags: review?(dkeeler)
Attachment #8519451 - Flags: review?(dkeeler) → review+
(Assignee)

Comment 1

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/7861642096c0
https://hg.mozilla.org/mozilla-central/rev/7861642096c0
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.