109598 - tasks overlays should use insertbefore, insertafter instead of position

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[nnooiissee]

mac classic has bugs with position for menus, so chatzilla ends up at position 5
in the tasks menu. a (more elegant) work around is to give each component
menuitem in the tasks menu a id, and use insert before, insert after.

i have this working, i just need to get a clean tree to diff with.

Comment 1

[nnooiissee]

Attachment: add ids to navigator and editor menuitem's

Comment 2

[nnooiissee]

Attachment: add ids to messenger components, and use the ids from the last patch

Comment 3

[nnooiissee]

Attachment: make chatzilla use ids from the first patch, and give cz an id for the hell of it

Comment 4

[nnooiissee]

rginda: could i milk you for a r= for these patches?

Comment 5

[nnooiissee]

ben, mpt, rginda asked me to have you two look at this and comment.

<rginda>nnooiissee: looks ok to me, but please get mpt and goodger to comment

Comment 6

[nnooiissee]

Attachment: add the ids i actualy use in the later patches to navigator and editor menuitems

Comment 7

[nnooiissee]

*** Bug 109247 has been marked as a duplicate of this bug. ***

Comment 8

[nnooiissee]

to continue in my monolog...

i tested these patches on netscape 6.2, and they go in clean and nothing changes
in the order of the tasks menu.

Comment 9

[xyzzy]

*** Bug 113763 has been marked as a duplicate of this bug. ***

Comment 10

[xyzzy]

Please resummarize to make the summary more search friendly!

Comment 11

[Håkan Waara]

Can we get some traction on these patches? They just need review. Btw, I think
they'll fix another bugreport I saw about chatzilla ending up in the wrong
position in the Tasks menu.

Blake, bz, rginda, ben?  ...

Comment 12

[andreww]

would http://bugzilla.mozilla.org/show_bug.cgi?id=118263
be a dupe of this?

Comment 13

[andreww]

mmooiissee : if you can confirm that these patches still work in today's builds
- Ill review these patches today...

and if you need someone to check them in after you get SR let me know.

Comment 14

[nnooiissee]

andreww: i am deping bug 118263 on this. i will test whatever newest (mac) build 
i have when i get home, and upload a modified patch as needed. hopefully this 
evening.

I have been having trouble getting a sr on these, but i will try again. glad to 
know someone cares. if you want to take this off of my hands, feel very welcome 
to.

Comment 15

[andreww]

ok - I have a cousin-bug of this in bugscape (commercial tree) so perhaps 
I can use that and this bug together to fix all of it at once....

Comment 16

[andreww]

Comment on attachment 57417 [details] [diff] [review]
add ids to messenger components, and use the ids from the last patch

r=andreww

Comment 17

[andreww]

Comment on attachment 57418 [details] [diff] [review]
make chatzilla use ids from the first patch, and give cz an id for the hell of it

r=andreww - please try to put these together into one patch next time

Comment 18

[andreww]

Comment on attachment 57467 [details] [diff] [review]
add the ids i actualy use in the later patches to navigator and editor menuitems

r=andreww

Comment 19

[Johnny Stenback (:jst)]

Comment on attachment 57417 [details] [diff] [review]
add ids to messenger components, and use the ids from the last patch

sr=jst

Comment 20

[Johnny Stenback (:jst)]

Comment on attachment 57418 [details] [diff] [review]
make chatzilla use ids from the first patch, and give cz an id for the hell of it

sr=jst

Comment 21

[Johnny Stenback (:jst)]

Comment on attachment 57467 [details] [diff] [review]
add the ids i actualy use in the later patches to navigator and editor menuitems

sr=jst

Comment 22

[Håkan Waara]

Patches checked in for [e-mail]; marking fixed.