1096011 - Report in NS_WARNING output for which contract id it failed to load the JS implementation (BindingUtils.cpp)

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Frank Wein [:mcsmurf]]

This is basically related to Bug 876602.
Before the patch in that bug the warning message (NS_WARNING) reported the contract id when a JS implementation failed to load:
-    nsCOMPtr<nsISupports> implISupports = do_CreateInstance("${contractId}");
-    if (!implISupports) {
-      NS_WARNING("Failed to get JS implementation for contract \\"${contractId}\\"");
-      aRv.Throw(NS_ERROR_FAILURE);
-      return nullptr;
-    }

The new code in BindingUtils.cpp does not do that:
+    nsCOMPtr<nsISupports> implISupports = do_CreateInstance(aContractId);
+    if (!implISupports) {
+      NS_WARNING("Failed to get JS implementation for contract");
+      aRv.Throw(NS_ERROR_FAILURE);
+      return nullptr;
+    }

I think it should still be possible (and helpful) to add the contract id to the warning text here?

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Warning when failing to create a JS implemntation for a Web IDL binding should include the implementation contract

Comment 2

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d2beb971bb6e

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d2beb971bb6e