1096036 - Desktop application name should change from FirefoxAurora to FirefoxDeveloperEdition on update

Status: RESOLVED WONTFIX

(Firefox :: General, defect)

Description

[Tracy Walker [:tracy]]

Start with an Aurora nightly build, then via update get the DevEd.  The desktop icon correctly changes to the blue fox. However, then application name remains FirefoxAurora.

This should update itself to FirefoxDeveloperEdition

Comment 1

[Brian Grinstead [:bgrins]]

(In reply to [:tracy] Tracy Walker - QA Mentor from comment #0)
> Start with an Aurora nightly build, then via update get the DevEd.  The
> desktop icon correctly changes to the blue fox. However, then application
> name remains FirefoxAurora.
> 
> This should update itself to FirefoxDeveloperEdition

How do you update from aurora -> dev edition currently?  If I download an earlier build from https://tbpl.mozilla.org/?tree=Mozilla-Aurora, for instance, then it checks for updates but doesn't find any.

Comment 2

[Tracy Walker [:tracy]]

Brian, updates are available on auroratest channel.

Change channel to auroratest in channel-prefs.js in the application directory > defaults > pref

Comment 3

[Brian Grinstead [:bgrins]]

Panos, do you think this will be fixed by Bug 1095934?  And will therefore not be an issue on the aurora update channel?

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

I doubt this particular change will have any effect on this. I don't know why the name wouldn't change in the desktop icon. Which platform are we talking about here, Mac, Windows, Linux? And which icon, just a regular desktop icon or the dock, quick launch toolbar, etc.?

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

On Linux, for instance, I know that the desktop icon/launcher is something separate from the app and doesn't update automatically. I don't know how we could fix that without manual user intervention.

Comment 6

[Tracy Walker [:tracy]]

I reported this on Mac.  It's the application name that isn't updated.  The icon itself is fine. I install on the desktop, not in the application folder.

Comment 7

[Brian Grinstead [:bgrins]]

(In reply to [:tracy] Tracy Walker - QA Mentor from comment #6)
> I reported this on Mac.  It's the application name that isn't updated.  The
> icon itself is fine. I install on the desktop, not in the application folder.

Do the default pref changes also get made (i.e. dark theme is on by default - browser.devedition.theme.enabled is set to try when user pref is reset)?

Comment 8

[Tracy Walker [:tracy]]

(In reply to Brian Grinstead [:bgrins] from comment #7)  

> Do the default pref changes also get made (i.e. dark theme is on by default
> - browser.devedition.theme.enabled is set to try when user pref is reset)?

Aurora gets updated correctly to DevEdition browser.  browser.devedition.theme.enabled config is set to true.  Which pref are you saying to reset?

Comment 9

[Brian Grinstead [:bgrins]]

> Aurora gets updated correctly to DevEdition browser. 
> browser.devedition.theme.enabled config is set to true.  Which pref are you
> saying to reset?

I meant reset browser.devedition.theme.enabled just to make sure that true is the default value.

Comment 10

[Gabriela [:gaby2300]]

IS it necessary to reset the preference? Shouldn't it be changed during the update?

Comment 11

[Brian Grinstead [:bgrins]]

(In reply to Gabriela [:gaby2300] from comment #10)
> IS it necessary to reset the preference? Shouldn't it be changed during the
> update?

I assumed that updating doesn't reset user-set prefs.  So just trying to figure out if this is related to 1095934, where the default prefs aren't set when not on the aurora update channel.  However, it sounds like it's not a duplicate issue - in that case I did see the correct name/logo but just not the default prefs.

Comment 12

[Kamil Jozwiak [:kjozwiak]]

I ran into the same issue on Win 8.1 x64. When updating an older version of aurora to the Developer Edition, the desktop icon text still appears as "Aurora" rather than "Firefox Developer Edition", example:

- download an older version of aurora [I used: 2014-10-25-00-40-02-mozilla-aurora]
- change channel-prefs.js to "auroratest" and update the build
- You'll notice that the theme of the icon will change but the text will still appear as "Aurora"

Comment 13

[Panos Astithas (he/him) [:past] (please ni?)]

Rob, is it expected that updating Aurora to Developer Edition will not change the desktop icon name and is there a way around that?

Comment 14

[:Gavin Sharp [email: [e-mail]]]

We don't have any code for renaming shortcuts or app bundle names on update, as far as I know.

I think this is WONTFIX - new users will have things work correctly, and fixing things for existing Aurora users is not worth the trouble.

Comment 15

[Justin Crawford [:hoosteeno] [:jcrawford]]

If we WONTFIX this can we add a quick workaround to this bug? Is it as simple as "rename the icon"?

Comment 16

[Panos Astithas (he/him) [:past] (please ni?)]

Yes, or even download the app again. The profile data will remain intact and be reused.

Comment 17

[Tracy Walker [:tracy]]

(In reply to Justin Crawford [:hoosteeno] from comment #15)
> If we WONTFIX this can we add a quick workaround to this bug? Is it as
> simple as "rename the icon"?

Yes. rename is the simple workaround.

Comment 18

[Robert Strong (they/them - no direct email)]

We investigated this for Firefox 5 channel switching and there isn't a simple workaround. For Mac changing the bundle name will break secondary user dock entries. For Windows, there are shortcuts shared by all users and changing it will be confusing for secondary users and we won't be able to change the shortcut name for shortcuts that are specific to a secondary user since the update won't happen as that user.