1096126 - Push to reviewboard on Windows hangs

Status: RESOLVED WORKSFORME

(MozReview Graveyard :: General, defect, P2)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

I'm unable to push to reviewboard on Windows. It just sits there indefinitely, after the following is logged:

$ hg push review --verbose --debug
pushing to ssh://reviewboard-hg.mozilla.org/gecko
running "C:\Program Files (x86)\PuTTY\plink.exe" reviewboard-hg.mozilla.org "hg -R gecko serve --stdio"
sending hello command
sending between command


I have it working fine on Linux. And I've applied the patch from bug 1092476, so I don't think it's that. Running Mercurial 3.2, and tip of version-control-tools repo.

Comment 1

[Mark Côté [:mcote]]

You are able to push from Windows, correct?

Comment 2

[Ed Morley [:emorley]]

Yes, though I see bug 1140223 (but pushing a review still seems to work) - not sure if that's Windows specific or not.

[~/src]$ hg --version | head -n 1
Mercurial Distributed SCM (version 3.3.2)
[~/src]$ which hg
/c/Program Files/TortoiseHg/hg
[~/src]$ python --version
Python 2.7.9
[~/src]$ cat ~/.hgrc | grep 'ssh' | sed 's/mozilla.com/snip/'
ssh = tortoiseplink.exe -ssh -2 -batch -C -l emorley@snip -i %USERPROFILE%\.ssh\moco_rsa.ppk

Using latest version-control-tools.

Comment 3

[Ed Morley [:emorley]]

Blair, can you try an |ssh reviewboard-hg.mozilla.org| to check you don't need to accept the new addition to known_hosts?

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Just remembered this bug when I hit it again (I've been on leave for ~9 months, so this is the first time in ages I've tried).

(In reply to Ed Morley [:emorley] from comment #3)
> Blair, can you try an |ssh reviewboard-hg.mozilla.org| to check you don't
> need to accept the new addition to known_hosts?

Nope, still the same problem after that.



> $ hg push review --verbose --debug
> automatically setting Bugzilla API Key auth https://reviewboard-hg.mozilla.org
> pushing to ssh://reviewboard-hg.mozilla.org/autoreview
> running "C:\Program Files (x86)\PuTTY\plink.exe" reviewboard-hg.mozilla.org "hg -R autoreview serve --stdio"
> sending hello command
> sending between command

Comment 5

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to Mark Côté [:mcote] (on PTO until January 28) from comment #1)
> You are able to push from Windows, correct?

Oh, and yes, I normally push from Windows.

Comment 6

[Piotr Zalewa [:zalun]]

[:imadueme] could you confirm and possibly close?

Comment 7

[Israel Madueme [:imadueme]]

I will test later today or tomorrow.

Comment 8

[Israel Madueme [:imadueme]]

Woops! This slipped my mind. Going to verify first thing in the morning.

Comment 9

[Piotr Zalewa [:zalun]]

This could be related to bug 1353308

Comment 10

[Israel Madueme [:imadueme]]

Attachment: test bug 1096126

Review commit: https://reviewboard.mozilla.org/r/126516/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/126516/

Comment 11

[Israel Madueme [:imadueme]]

I was able to push to reviewboard from windows using https://reviewboard-hg.mozilla.org.
ssh://reviewboard-hg.mozilla.org doesn't work with PuTTY giving a fatal error: "Server unexpectedly closed server connection".

I think we can possibly close this, and give instructions to push via https instead of ssh. Note, I did not try a path with a space like bug 1353308 suggests - so that could be a separate issue.

Here is the output of the successufll HTTP push (this works on normal Windows cmd and Git Bash)

```
C:\Users\mozilla\work\version-control-tools>hg push -r . https://reviewboard-hg.mozilla.org/version-control-tools
pushing to https://reviewboard-hg.mozilla.org/version-control-tools
(adding commit id to 1 changesets)
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 11 changesets with 1 changes to 11 files (+1 heads)
remote: recorded push in pushlog
submitting 1 changesets for review

changeset:  5230:50d52924dc02
summary:    test bug 1096126
review:     https://reviewboard.mozilla.org/r/126516 (draft)

review id:  bz://1096126/imadueme
review url: https://reviewboard.mozilla.org/r/126514 (draft)

(review requests lack reviewers; visit review url to assign reviewers)

publish these review requests now (Yn)?  y
(published review request 126514)
```