Closed
Bug 1096152
Opened 10 years ago
Closed 10 years ago
Use frame instead of content for tracking break position
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: xidorn, Assigned: xidorn)
References
Details
Attachments
(1 file, 2 obsolete files)
22.11 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
We need to track break position in some pseudo frame, hence it would be helpful to use frame instead of content for recording and forcing break.
Assignee | ||
Comment 1•10 years ago
|
||
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=d1cbc8b617b2
Attachment #8519697 -
Flags: review?(dbaron)
Assignee | ||
Comment 2•10 years ago
|
||
Sorry for the silly problem. https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=67d173d98b7d
Attachment #8519697 -
Attachment is obsolete: true
Attachment #8519697 -
Flags: review?(dbaron)
Assignee | ||
Updated•10 years ago
|
Attachment #8519699 -
Flags: review?(dbaron)
Assignee | ||
Updated•10 years ago
|
Summary: Use first-in-flow frame instead of content for tracking break position → Use frame instead of content for tracking break position
Assignee | ||
Comment 3•10 years ago
|
||
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=fd01d69a33cc
Attachment #8519699 -
Attachment is obsolete: true
Attachment #8519699 -
Flags: review?(dbaron)
Attachment #8521145 -
Flags: review?(dbaron)
Comment on attachment 8521145 [details] [diff] [review] patch r=dbaron I don't see anything in bug 343445 explaining why content is preferable to frames here, and having to deal with anonymous boxes is a good reason that frames are preferable to content.
Attachment #8521145 -
Flags: review?(dbaron) → review+
Assignee | ||
Comment 5•10 years ago
|
||
inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/e299958f1fd5
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e299958f1fd5
Assignee: nobody → quanxunzhen
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•