Closed
Bug 1096236
Opened 10 years ago
Closed 10 years ago
Remove "alternateLayoutOverwrite" in Arabic layout definition
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Firefox OS Graveyard
Gaia::Keyboard
Tracking
(b2g-v2.2 fixed)
RESOLVED
FIXED
2.2 S1 (5dec)
Tracking | Status | |
---|---|---|
b2g-v2.2 | --- | fixed |
People
(Reporter: rudyl, Assigned: xeonchen, Mentored)
Details
(Whiteboard: [good first bug][lang=js][mentor-lang=zh])
Attachments
(1 file)
The "alternateLayoutOverwrite" is not referenced in our current code, so it should be removed. https://github.com/mozilla-b2g/gaia/blob/ba0337ffddb62ef3cf388b904e25966d30c89609/apps/keyboard/js/layouts/ar.js#L68
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8528965 -
Flags: review?(rlu)
Reporter | ||
Comment 3•10 years ago
|
||
Comment on attachment 8528965 [details] [review] pull request Looks good to me. r+ Thanks! Please help set checkin-needed or ni'ed me if the gaia-try passed.
Attachment #8528965 -
Flags: review?(rlu) → review+
Comment 5•10 years ago
|
||
Master: https://github.com/mozilla-b2g/gaia/commit/7de6843d8fd05079b98aae304320cc0ec7ba2865
Reporter | ||
Comment 6•10 years ago
|
||
Thanks!
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•