Closed Bug 1096236 Opened 6 years ago Closed 5 years ago

Remove "alternateLayoutOverwrite" in Arabic layout definition

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

defect
Not set

Tracking

(b2g-v2.2 fixed)

RESOLVED FIXED
2.2 S1 (5dec)
Tracking Status
b2g-v2.2 --- fixed

People

(Reporter: rudyl, Assigned: xeonchen, Mentored)

Details

(Whiteboard: [good first bug][lang=js][mentor-lang=zh])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
rudyl
: review+
Details | Review
The "alternateLayoutOverwrite" is not referenced in our current code, so it should be removed.
https://github.com/mozilla-b2g/gaia/blob/ba0337ffddb62ef3cf388b904e25966d30c89609/apps/keyboard/js/layouts/ar.js#L68
I'll take this as my first bug.
Assignee: nobody → xeonchen
Attached file pull request
Attachment #8528965 - Flags: review?(rlu)
Comment on attachment 8528965 [details] [review]
pull request

Looks good to me. r+
Thanks!

Please help set checkin-needed or ni'ed me if the gaia-try passed.
Attachment #8528965 - Flags: review?(rlu) → review+
test passed.
Keywords: checkin-needed
Thanks!
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.