1096251 - Add the ability to query flag activity by attachment-id

Status: NEW

(bugzilla.mozilla.org :: Extensions, enhancement)

Description

[Kevin Grandon :kgrandon]

We have a few cases where it might be useful to surface the last flag requestee on an attachment after a flag is changed. It seems this information is available on the attachment API before the flag is set, but once it's set the info is no longer available.

I realize that you may be able to infer this from the change history of a bug, but I think it may be much easier if the attachment API could surface this for us.

Comment 1

[David Lawrence [:dkl]]

We would have to change the current code behavior to not clear out the requestee value when a flag is set to + or - from a ?. If we did that we could still show the requestee value but not sure if that would cause confusion to others who are not expecting it. we would need to see what amount of work this would need and what would break.

dkl

Comment 2

[Kevin Grandon :kgrandon]

Thanks. Preserving the requestee value on flag set would suit my use case. Trying to morph the title into something that more resembles that solution, but feel free to update it to make it more clear if needed.

Comment 3

[Dylan Hardison [:dylan] (he/him)]

This information is already available using the flag history API, which is used for the Review History UI, for instance.

Comment 4

[Kevin Grandon :kgrandon]

(In reply to Dylan William Hardison [:dylan] from comment #3)
> This information is already available using the flag history API, which is
> used for the Review History UI, for instance.

I see the /rest/bug/<id>/history endpoint, but I don't see the flag history endpoint. Is there another rest endpoint for this? If so - could you point me to it? Thanks!

Comment 5

[:glob ✱]

you can't currently search by attachment-id, however the data is in the table so it shouldn't be difficult to expose it.

unfortunately the issue for finding a home for the docs of BMO specific APIs is still ongoing.
for now i've put our POD docs up on the wiki at https://wiki.mozilla.org/BMO/REST/review#flag_activity

Comment 6

[Kevin Grandon :kgrandon]

David/Dylan - Do you guys have any suggestions about next steps here? It seems that the flag history API is a bit buggy (see bug 1106904), so ideally I would like to see if we can persist the requestee field for flags.

Comment 7

[Dylan Hardison [:dylan] (he/him)]

I've commented in bug 1106904 comment #1 with the suggestion to inline the generate_history function that the review history UI uses, which may be more generally useful. I think we could allow searching by attachment id as well.