1096260 - some callers of nsIFrame::ComputeSize still pass a bool for the last parameter instead of a flags word

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[Jonathan Kew [:jfkthame]]

This parameter was changed in bug 732610, but some callers were apparently missed (or have been added since?), and so they still pass a literal bool. This compiles without complaint, as the bool automatically gets promoted to uint32_t, but makes the code misleading and error-prone.

See callers in nsFrame::BoxReflow(), FloatMarginISize(), and ChildShrinkWrapWidth().

I suggest we change the flags parameter from plain uint32_t to a typed enum, which will force callers to explicitly pass the correct type.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Convert flags parameter of nsIFrame::ComputeSize from uint32_t to a typed enum, and update callers accordingly.

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 8519880 [details] [diff] [review]
Convert flags parameter of nsIFrame::ComputeSize from uint32_t to a typed enum, and update callers accordingly.

Thanks for catching this!

Comment 3

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/be1f8816683e

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/be1f8816683e