Closed Bug 1096274 Opened 10 years ago Closed 10 years ago

Reviewer replies via /comm are being logged as private comments

Categories

(Marketplace Graveyard :: Reviewer Tools, defect)

Product:
Marketplace Graveyard
Component:
Reviewer Tools
Version:
2014-Q4
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1095923

People

(Reporter: eviljeff, Assigned: kngo)

References

Details

It appears that when a reviewer (others??) writes a reply via the commbadge thread interface on /comm that the reply is saved as a type 'Reviewer Comment'.  Which makes perfect sense - unfortunately 'Reviewer Comments' are actually private, reviewer only, comments which the developers can't see.  So they can't see (and presumably don't receive via email) our replies.
Yeah, I noticed this too. The fix will deploy Tuesday.
Assignee: nobody → kngo
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
The reviewer comments as of now will be marked as "Internal Reviewer Comment". And public reviewer comments will be marked as "Reviewer Comment".

https://github.com/mozilla/zamboni/commit/de5c959d9d1104b5c84d4192240bc70cf0b11080
https://github.com/mozilla/zamboni/commit/9f0720de6bea7ff291d728bb4d297955cc510fcd
Plus, sorry, forgot to notify the reviewer team about this.
Cool.  I was thinking they should be 'private reviewer comment' to be explicit about the visibility.  I'll log a bug.
You need to log in before you can comment on or make changes to this bug.