Closed
Bug 1096312
Opened 10 years ago
Closed 10 years ago
Crash in Octane 2.0 benchmark demo
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 1095973
People
(Reporter: streetwolf52, Unassigned)
References
Details
(Keywords: regression)
Through regression checking I've found that Bug 1090537 causes the Octane 2.0 benchmark to crash Fx when I click on it's link. I don't even get into the web site. GOOD ---- 20141107193030 https://hg.mozilla.org/integration/mozilla-inbound/rev/818ef4dc2697 BAD --- 20141107223006 https://hg.mozilla.org/integration/mozilla-inbound/rev/aca93ae7eeed Here's the crash report but since I'm on inbound (no symbols?) I don't know if it is helpful: https://crash-stats.mozilla.com/report/index/c19cd197-9a8b-4fd0-a68a-098f82141109 Might be the same problem as Bug 1095973 --------------------- Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:36.0) Gecko/20100101 Firefox/36.0
Reporter | ||
Updated•10 years ago
|
Blocks: 1090537
Keywords: regression
Comment 1•10 years ago
|
||
Gary, does this reproduce for you in a clean profile? We can't reproduce it but I'd really like to get to the bottom of this.
Reporter | ||
Comment 2•10 years ago
|
||
Things are working fine all of a sudden even with my normal profile. I even went back to the 'bad' cset I mentioned and had no problems. I know it crashed this morning after updating to what was the latest inbound at the time. I'm now trying to remember if I made any changes since then that would account for things working again.
Reporter | ||
Comment 3•10 years ago
|
||
Perhaps it was a site problem that showed itself with the 'bad' cset and was subsequently fixed? Just guessing.
Comment 4•10 years ago
|
||
Was e10s enabled when it crashed?
Reporter | ||
Comment 5•10 years ago
|
||
I really can't remember if I tried it under e10s. However, it now works on e10s and non e10s.
Reporter | ||
Comment 6•10 years ago
|
||
What I found strange about the crash is that I got it just clicking on my bookmark for it. It wasn't like I ran the benchmark. I never even got into it.
Reporter | ||
Comment 7•10 years ago
|
||
Actually I used the link on my location bar dropdown menu.
Reporter | ||
Comment 8•10 years ago
|
||
The freaking site is now crashing again.
Comment 9•10 years ago
|
||
(In reply to Gary [:streetwolf] from comment #8) > The freaking site is now crashing again. Awesome. Is this with e10s? Can you try with a clean profile? Or with some addons disabled? I tried to repro on Windows 8 with a 64-bit PGO build but it doesn't crash...
Reporter | ||
Comment 10•10 years ago
|
||
Doesn't crash with a clean profile, e10s and non-e10s. Crashes both ways on my normal profile even in safe mode. But it was working with all my add-ons. Let me disable them one by one and see what happens.
Reporter | ||
Comment 11•10 years ago
|
||
I run the ad blocker AdGuard. I run the Windows standalone version. It's just another running program. When I disable it Octane works. I thought I eliminated AG as the culprit in the past. In fact, I think AG was enabled when it was working a little while ago. Let me delve further into this.
Reporter | ||
Comment 12•10 years ago
|
||
I am totally stumped. Now it's crashing again even with AG disabled. The only version that doesn't crash is the one I marked as GOOD above.
Reporter | ||
Comment 13•10 years ago
|
||
Sorry about all my comments. Octane is now working again with AG enabled or disabled. I'll try to see if I can find the point at which Octane crashes gain.
Reporter | ||
Comment 14•10 years ago
|
||
I switched over to https://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-win64-pgo/ which does include the 'bad' patch and I also crash. Not surprising. I'll try to pursue the crash as if it's an AdGuard problem.
Comment 15•10 years ago
|
||
Thanks Gary. I got a crash with AdGuard installed so that does seem to be the culprit...
Reporter | ||
Comment 16•10 years ago
|
||
Now to stir the pot. I am running with a clean boot. Only MS stuff. I still get the crash. Unless AG is modifying something that persists.
Reporter | ||
Comment 17•10 years ago
|
||
Why don't we close this out then?
Comment 18•10 years ago
|
||
Let's not close it --- just because AdGuard triggers it doesn't mean it's not a JS engine bug. I'm not at work today, but I'll be back Monday and I'd like to work on this then.
Flags: needinfo?(jorendorff)
Comment 19•10 years ago
|
||
Actually, Gary, maybe bug 1095973 fixed this. Try it in today's Nightly?
Flags: needinfo?(jorendorff) → needinfo?(garyshap)
Reporter | ||
Comment 20•10 years ago
|
||
Yeah, it looks like it did fix it. I managed to get around the problem by including the Octane site in AdGuard's whitelist. When I disabled it in AG Octane works. Nice find.
Flags: needinfo?(garyshap)
Comment 21•10 years ago
|
||
Thanks for confirming.
Status: UNCONFIRMED → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•