1096327 - Invalid e-mail format is accepted in FxA-migration window at “Sign In”

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Description

[Iulian Timis]

Steps to reproduce:
1. Load MP-stage homepage ( https://marketplace.allizom.org/ )
2. Click the “Sign in” button from the page header.
3. Enter an invalid e-mail ( i.e. test@t)

Expected results:
The message “Valid e-mail required” is displayed. The "Next" button is gray and inactive. 

Actual results:
The “Next” button is blue and active. The user can continue with the invalid entered email.

Verified on FF36 (Win 7). Issue is also reproducing on MP-dev.
Screencast for this issue: http://screencast.com/t/ZxhW3IOEZ9kh

Comment 1

[[e-mail]]

foo@tld (with no dots) is actually a valid email address:

"In the case  of a top-level domain used by itself in an email address, a single string is used without any dots" [1]

Which is probably why the email type is quite liberal in what it accepts.

[1] http://tools.ietf.org/html/rfc5321#section-2.3.5

Comment 2

[Andy McKay]

Based on comment 1.

Comment 3

[Iulian Timis]

If the entered email is valid, then the "Valid email required" error should not be displayed in the registration form. Please see screencast http://screencast.com/t/N9XYARdB

Comment 4

[[e-mail]]

(In reply to Iulian Timis from comment #3)
> If the entered email is valid, then the "Valid email required" error should
> not be displayed in the registration form. Please see screencast
> http://screencast.com/t/N9XYARdB

Technically as per comment 1 foo@tld should be allowed with no dots. But looking at fxa content server they're explicitly doing their own validation and explicitly making it look for at least one dot.

https://github.com/mozilla/fxa-content-server/blob/master/app/scripts/lib/validate.js

I'll raise a github issue and see what they say - if they have good reasons for doing this then we should update and follow suite even if it goes against the spec.

Comment 5

[[e-mail]]

Filed https://github.com/mozilla/fxa-content-server/issues/1871

Comment 6

[[e-mail]]

PR on the FxA side is here: https://github.com/mozilla/fxa-content-server/pull/1909/files

Shane expect it'll be another couple of weeks before it sees prod.

Comment 7

[[e-mail]]

The FxA fix for this has landed here https://github.com/mozilla/fxa-content-server/commit/5ae2aef1c5a80017e5e1e51e3e91c2ab5ac5d52b

As noted in comment 6 it might be a while before this is released to prod, but there's nothing to do at our end.

Comment 8

[Iulian Timis]

Verified as fixed in https://marketplace.allizom.org/ on FF37 (Win 7).
Postfix screencast http://screencast.com/t/QHabWyPWA7L
Closing bug.