1096378 - Don't allow duplicate parameter names in concise method definitions

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[André Bargull [:anba]]

Test case:
---
({m(a, a){}})
---

Expected: SyntaxError is thrown
Actual: No SyntaxError

Concise method definition parameters use the 'StrictFormalParameters' grammar production [1] which disallows duplicate parameter names [2].

[1] https://people.mozilla.org/~jorendorff/es6-draft.html#sec-method-definitions
[2] https://people.mozilla.org/~jorendorff/es6-draft.html#sec-function-definitions-static-semantics-early-errors

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Disallow duplicated parameter in method definition.

applied after the patch in bug 1096376 and bug 1096377.

Already passed the try (same as bug 1096376):
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=91855352a697

Comment 2

[Tooru Fujisawa [:arai]]

Thank you :)

https://hg.mozilla.org/integration/mozilla-inbound/rev/2123d6dfed88

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2123d6dfed88

Comment 4

[Kohei Yoshino]

https://developer.mozilla.org/en-US/Firefox/Releases/38/Site_Compatibility