Closed Bug 1096378 Opened 9 years ago Closed 9 years ago

Don't allow duplicate parameter names in concise method definitions

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: anba, Assigned: arai)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete, site-compat)

Attachments

(1 file)

Test case:
---
({m(a, a){}})
---

Expected: SyntaxError is thrown
Actual: No SyntaxError

Concise method definition parameters use the 'StrictFormalParameters' grammar production [1] which disallows duplicate parameter names [2].

[1] https://people.mozilla.org/~jorendorff/es6-draft.html#sec-method-definitions
[2] https://people.mozilla.org/~jorendorff/es6-draft.html#sec-function-definitions-static-semantics-early-errors
applied after the patch in bug 1096376 and bug 1096377.

Already passed the try (same as bug 1096376):
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=91855352a697
Attachment #8553309 - Flags: review?(jorendorff)
Blocks: es6
Attachment #8553309 - Flags: review?(jorendorff) → review+
https://hg.mozilla.org/mozilla-central/rev/2123d6dfed88
Assignee: nobody → arai_a
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.