Closed Bug 1096396 Opened 7 years ago Closed 7 years ago

CSP: test_connect-src.html should have return statement after SimpleTest.finish()

Categories

(Core :: DOM: Security, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: ckerschb, Assigned: ckerschb)

References

Details

Attachments

(1 file)

When debugging the B2G test failures for a different bug, I encountered this [1]:
> JavaScript error: http://mochi.test:8888/tests/dom/base/test/csp/test_connect-src.html, line 100: TypeError: tests[counter] is undefined

We should add a return statement after SimpleTest.finish(), see [1]:

http://mxr.mozilla.org/mozilla-central/source/dom/base/test/csp/test_connect-src.html?force=1#93
Blocks: 1031530
Attachment #8519998 - Flags: review?(dveditz)
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Comment on attachment 8519998 [details] [diff] [review]
bug_1096396_test_fix.patch

r=dveditz
Attachment #8519998 - Flags: review?(dveditz) → review+
https://hg.mozilla.org/mozilla-central/rev/4e9a7b690543
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.