1096435 - Clone task data is permanently saved under /create

Status: VERIFIED FIXED

(Mozilla QA Graveyard :: One and Done, defect)

Description

[Rebecca Billings [:rbillings]]

If a user has visited the clone task page, all of the cloned task data is saved on /create. If the user does not choose to create the cloned task, the data should not be saved.

1) view task detail 
2) click clone task
3) return to available tasks [or any other page]
4) click create task button or go to /create via the header

expected: create task page with blank fields
actual: create task page is filled with cloned task data - data is preserved after leaving /create, after logging out, using a different browser, etc.

Comment 1

[Bob Silverberg [:bsilverberg]]

Attachment: Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/215

Comment 2

[Bob Silverberg [:bsilverberg]]

This bug also manifests as a different task being presented when editing an existing task. The patch I am attaching addresses both issues.

Comment 3

[Bob Silverberg [:bsilverberg]]

Commit pushed to master at https://github.com/mozilla/oneanddone

https://github.com/mozilla/oneanddone/commit/54cb2c0296a781f2ace68e76f8ce0904dd42fa1d
Bug 1096435 - Clone task data is permanently saved under /create

Fix code to not set view.initial but rather to return the proper kwargs for the form

Comment 4

[Bob Silverberg [:bsilverberg]]

This has been fixed and pushed to dev and stage.

Comment 5

[Rebecca Billings [:rbillings]]

Verified on staging

Comment 6

[Rebecca Billings [:rbillings]]

Verified on prod