Closed Bug 1096541 Opened 8 years ago Closed 8 years ago
firefox dev edition feedback responses have no platform
The feedback responses for the Firefox Dev edition don't have values in the platform field. This bug covers figuring out why that is, fixing the code involved (pretty sure we should infer it from the user agent) and then writing a data migration to backfill the platform field for existing Firefox Dev edition responses.
Grabbing this to look into now.
Assignee: nobody → willkg
Status: NEW → ASSIGNED
The platform inferring code is a total mess. I'm going to fix this in conjunction with bug #1087391 and bug #1087387. The new way to do it is this: 1. we add a new browser_platform field that will always have the platform we inferred from the user agent in it 2. fix the api to infer the browser_* fields if the user_agent was passed in 3. clean up the rest of the inference code to be "more correct" 4. write a data migration to backfill the browser_platform field with what we sussed out of the user agent Going forward all responses that have a user_agent will have a browser_platform field filled in. I'm going to implement that all in the first pass. I'm mostly done now. However, the conundrum we end up with is this: "Firefox dev" doesn't match "Firefox", so the product we get from the url won't match the product we infer from the user agent so we won't fill in the platform field. The front page dashboard and analyzer search facet on "platform"--not "browser_platform". Also, the front page dashboard doesn't show the browser_* fields. I need to figure out a generally good "matching" system that allows me to connect Input products with the browser inferred from the user agent so we know when it's appropriate to copy browser_platform to platform. Fixing that will be in the second pass. The end goal is that we should always be confident that the platform is correct even in cases where we guessed it.
Landed in master in: https://github.com/mozilla/fjord/commit/f5d8b56e66be781eb1a5a8a6c2405a0ea4e79d8b Still need a backfill data migration.
Pushed everything so far to production. Still need to backfill the browser_platform field. I'll keep this bug open for that work.
Backfilled the platform and browser_platform data for Firefox dev in https://github.com/mozilla/fjord/commit/4796e4e2aabd8cb0d89151991e03dd721255891b Will push later.
Whiteboard: u=user c=feedback p= s=input.2014q4 → u=user c=feedback p=2 s=input.2014q4
Pushed. Closing this out.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.