1096613 - Move Windows firewall manifest to correct module

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: Puppet, task)

Comment 1

[Mark Cornmesser [:markco]]

Attachment: BUG1096613.patch

This moves the two windows manifest to the fw module. The firewall module is downloaded content from forge.

Comment 2

[Mark Cornmesser [:markco]]

Comment on attachment 8520249 [details] [diff] [review]
BUG1096613.patch

 https://hg.mozilla.org/build/puppet/rev/62268a5dad97

Comment 3

[Mark Cornmesser [:markco]]

Attachment: BUG1096613-corrections.patch

Correcting manifests:

Changing firewall to fw in class name to reflect module move 
Adding wht space after # in comments

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8523051 [details] [diff] [review]
BUG1096613-corrections.patch

That's a github diff page -- you need to add .patch to the end of the URL to get the plain-text patchfile.  So, https://github.com/markcor/build-puppet/commit/BUG1096613-3.patch in this case.

That said, the fixes look good -- I should have spotted that in the review!

Comment 5

[Mark Cornmesser [:markco]]

Comment on attachment 8523051 [details] [diff] [review]
BUG1096613-corrections.patch

https://hg.mozilla.org/build/puppet/rev/5a54be3ee293

Comment 6

[Pete Moore [:pmoore][:pete]]

Mark, FYI this change only goes live when merged from default branch to production branch in puppet, so I'll reopen the bug. We'll merge it in this morning, and if all goes ok, we can close the bug again.

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

Oh, sorry, I said I'd merge that and then spaced out.  Looks like mgerva did so when you opened this bug - 24e2dafcd856.