Closed Bug 1096634 Opened 5 years ago Closed 5 years ago

Treat ANGLE default framebuffer as RGB(A)

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: jgilbert, Assigned: jgilbert)

References

Details

Attachments

(1 file)

ANGLE treats the default framebuffer as BGR{X,A} for tests like those in CopyTexImage. Instead of special-casing this, let's just treat the backbuffer as RGB(A), since that's what it seems like it should be for EGL anyways.
Attachment #8520250 - Flags: review?(dglastonbury)
Comment on attachment 8520250 [details] [diff] [review]
0001-RGBA-backbuffers-for-ANGLE.patch

Review of attachment 8520250 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContext.cpp
@@ +1805,4 @@
>              formats.color_rbFormat  = LOCAL_GL_RGB8;
>          }
>      }
> +/*

Comment why this is commented out.
Attachment #8520250 - Flags: review?(dglastonbury) → review+
(In reply to Dan Glastonbury :djg :kamidphish from comment #1)
> Comment on attachment 8520250 [details] [diff] [review]
> 0001-RGBA-backbuffers-for-ANGLE.patch
> 
> Review of attachment 8520250 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: gfx/gl/GLContext.cpp
> @@ +1805,4 @@
> >              formats.color_rbFormat  = LOCAL_GL_RGB8;
> >          }
> >      }
> > +/*
> 
> Comment why this is commented out.

I removed it instead.
https://hg.mozilla.org/mozilla-central/rev/9ff0c451239b
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
See Also: → 1085203
Blocks: 1085203
See Also: 1085203
See Also: → 1149728
You need to log in before you can comment on or make changes to this bug.