Closed Bug 1096689 (fmradio-rtl) Opened 10 years ago Closed 6 years ago

[META] [RTL] FM Radio

Categories

(Firefox OS Graveyard :: Gaia::FMRadio, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: swilkes, Assigned: nefzaoui)

References

Details

(Keywords: meta, Whiteboard: [rtl-meta])

Attachments

(2 files)

This is the meta bug for RTL support in Ringtones. The release target for full Gaia (all apps) RTL support is 2.2. 

Per usual, strings for translation will be filed in the L10N component and noted as blocking this bug.

Rob's media app screenshots and work list needed to fit the bidi (Arabic) pattern are here:
https://mozilla.app.box.com/s/f6vagh798nsrpgrvscjm

The bidi UX pattern (OS wide) is here:
https://mozilla.app.box.com/s/0y1amh4rwpp6brcxd1hk
feature-b2g: --- → 2.2+
QA Whiteboard: [2.2-feature-qa+]
Attached image before.jpg
problem with frequency-dialer that's not pointing to the correct position and the channels start from 88 to 109
Attached image after.jpg
fixed 
frequency-dialer pointing to the correct position
channels start from 87 to 108
there's anything else ?? because It seems like that was the only thing...
QA Whiteboard: [2.2-feature-qa+]
feature-b2g: 2.2+ → ---
Thanks! Bhavana and I are reviewing 2.2 incremental improvements that may land. I agree the second screenshot looks good and fixes all issues, but we need a link to the patch. Thank you!
Flags: needinfo?(qudahmahmood)
I don't understand "link to the path" mean !
You need the code that i edited? Or what ?
Adding whiteboard tag [rtl-impact]
Whiteboard: [rtl-impact]
Mass Edit: adding the [rtl-meta]
Whiteboard: [rtl-impact] → [rtl-meta]
There are two obvious bugs here. Filing them and adding dependencies.
Assignee: nobody → nefzaoui
Depends on: 1114899
mozTrap test cases for RTL:
https://moztrap.mozilla.org/manage/case/15097/ [FMRadio] Tuner remains LTR in RTL language
https://moztrap.mozilla.org/manage/case/15098/ [FMRadio] Play controls remain LTR in RTL language
Whiteboard: [rtl-meta] → [rtl-meta][rtl-impact]
Depends on: 1115110
Whiteboard: [rtl-meta][rtl-impact] → [rtl-meta]
All done here. We're good to go :)
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(qudahmahmood)
Resolution: --- → FIXED
Depends on: 1119949
Reopening a bug as a new issue is found. A new dependency bug is added.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Depends on: 1126203
Depends on: 1126205
Depends on: 1130644
Depends on: 1131841
Keywords: meta
Firefox OS is not being worked on
Status: REOPENED → RESOLVED
Closed: 9 years ago6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: