Closed Bug 1096729 Opened 10 years ago Closed 9 years ago

add jshint to precommit lint pass

Categories

(support.mozilla.org :: Code Quality, task)

Product:
support.mozilla.org
Component:
Code Quality
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: mythmon, Unassigned)

References

Details

(Whiteboard: u=dev c=codequality p=2 s=) 

+++ This bug was initially created as a clone of Bug #1077422 +++

+++ This bug was initially created as a clone of Bug #1015788 +++

We've got a pre-commit hook that runs flake8 across changed python files.

This bug covers

1. building a JS linting system
2. integrating into scripts/lint.sh
3. fixing the existing files
4. adding JS linting to our CI tests (this should come for free from #2).
Pretty sure we're linting JS files now. Marking this as FIXED.

Mike: If that's not right, please re-open.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Technically we are using ESLint instead of JSHint. That's a minor issue though, we are linting JavaScript code, so this is indeed fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.