[Settings] All unit tests of settings app are not running

RESOLVED FIXED

Status

Firefox OS
Gaia::Settings
--
blocker
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: arthurcc, Assigned: eragonj)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

The issue was regressed by bug 1092934. The paths of the unit test files of the original settings app were overwritten by the ones of the settings app of tv.
Discussed with John Hu, Arthur and Ricky about this bug. In order not to block current development, we decided to rename "tv/settings -> tv/smart-settings" first to make unit tests runnable and will file another follow-up bugs for test agent.
Assignee: nobody → ejchen
Comment on attachment 8520389 [details] [review]
patch on master

@Dwi, can you help me review this patch ? thanks !

@Ricky, @Arthur and @John, need your feedbacks for this change, too !
Attachment #8520389 - Flags: review?(tzhuang)
Attachment #8520389 - Flags: feedback?(ricky060709)
Attachment #8520389 - Flags: feedback?(im)
Attachment #8520389 - Flags: feedback?(arthur.chen)
Comment on attachment 8520389 [details] [review]
patch on master

Looks good!
Attachment #8520389 - Flags: feedback?(arthur.chen) → feedback+
Comment on attachment 8520389 [details] [review]
patch on master

Looks good to me, Thanks!
Attachment #8520389 - Flags: review?(tzhuang) → review+
Comment on attachment 8520389 [details] [review]
patch on master

LGTM. thanks
Attachment #8520389 - Flags: feedback?(ricky060709) → feedback+
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.