There's another unnecessary restyle when appendChild() to #windows, it's because #windows has NODE_HAS_EDGE_CHILD_SELECTOR flag set from lockscreen/style/notifications.css: #notifications-lockscreen-container > div:last-child::after Since lockscreen.html now is integrated to system app (#lockscreen-frame-placeholder), import the CSS with limited scope can avoid this.
Summary: The last-child rule from lockscreen makes #windows → The div:last-child rule from lockscreen makes unnecessary restyle when appendChild() to #windows div
Assignee: nobody → tchou
Status: NEW → ASSIGNED
Attachment #8520360 - Flags: review?(gweng)
Comment on attachment 8520360 [details] [review] PR OK. I've tested this on my device. It looks fine and thanks for your patch.
Attachment #8520360 - Flags: review?(gweng) → review+
Comment on attachment 8520360 [details] [review] PR OK. I've re-flash it completely and the error occur. It looks like the old code (I now pull it directly from device to check it) has been pushed into the device, I should using make reset-gaia instead of make install-gaia. Please set the flag again if you fixed the issue.
Attachment #8520360 - Flags: review+
Addressed the issues of comment 3.
Comment on attachment 8521277 [details] [review] PR v2 OK. I now flash it twice to check if the patch is fine. Thanks.
Attachment #8521277 - Flags: review?(gweng) → review+
You need to log in before you can comment on or make changes to this bug.