1096758 - Publishing a review should clear r? flag

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect, P1)

Description

[Gregory Szorc [:gps]]

Per the discussion at https://groups.google.com/d/msg/mozilla-code-review/h575usEmrk4/WtxJlavyzk0J, we want to change review flag behavior such that publishing a review without Ship It will clear the r? flag on Bugzilla.

The eventual end state is we want a UI to differentiate between "review complete" and "review not complete" so the r? flag can linger. This enables partial reviews to be conducted while retaining a r? for tracking/nagging purposes. This is more complicated and will be punted to later.

Making this a P1 because people have complained about the existing behavior of having r? linger on review publish.

Comment 1

[Marco Bonardo [:mak]]

yes please, I use the bugzilla dashboard to track requests, and not cancelling a review means my queue never depletes.

moreover the review comments are posted as a common comment, that makes the bugmail invisible in the hundreds, while a Review Canceled: mail would be much more prominent.

Comment 2

[Gregory Szorc [:gps]]

Attachment: MozReview Request: bz://1096758/gps

Comment 3

[Gregory Szorc [:gps]]

/r/629 - reviewboard: clear r? when publishing a review (bug 1096758)

Pull down this commit:

hg pull review -r d88f2a902a2369414a9b5b4a2d950c2ed468af34

Comment 4

[Steven MacLeod [:smacleod]]

https://reviewboard.mozilla.org/r/629/#review289

Ship-It!

::: pylib/rbbz/rbbz/extension.py
(Diff revision 1)
> -        b.post_comment(bug_id, comment)
> +        cancelled = b.cancel_review_request(bug_id, review.user.email,

I'm wondering if we should only cancel if the reviewer opened issues? That's fine for a follow-up if we decide we would like that more.

Comment 5

[Steven MacLeod [:smacleod]]

https://reviewboard.mozilla.org/r/627/#review291

Ship It!

Comment 6

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/21deb18b3389

Comment 8

[Gregory Szorc [:gps]]

Attachment: MozReview Request: reviewboard: clear r? when publishing a review (bug 1096758)