Pushing an identical commit should not create a draft

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: gps, Assigned: dminor)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
Currently, when we push commits, we *always* create a new review request draft, event if nothing has changed.

I'm not 100% sure about this, but I *think* it is safe to just not create a new review request draft if nothing has changed. i.e. if the commit SHA-1 is the same, do nothing.

We may already do this. However, the push CLI says the review request is in the pending state. So, the server may be reporting state incorrectly.

I'm sure others will weigh in here...
Dan thinks this is fixed; he'll verify.
Assignee: nobody → dminor
(Assignee)

Comment 2

4 years ago
I was wrong, definitely not fixed.
(Assignee)

Updated

4 years ago
Depends on: 1144085
(Assignee)

Comment 3

4 years ago
Created attachment 8596610 [details]
MozReview Request: bz://1096761/dminor

/r/7505 - testing: add test to ensure re-review of revisions does not create a new draft (bug 1096761) r=gps

Pull down this commit:

hg pull -r de1f6ca3fbb230c9e25e4082269b6d67850f6abf https://reviewboard-hg.mozilla.org/version-control-tools/
Attachment #8596610 - Flags: review?(gps)
(Assignee)

Comment 4

4 years ago
With bug 1144085 fixed we're properly reporting whether something is a draft or not and this appears to be working as expected. I've added a test case to ensure it doesn't break in the future.
Status: NEW → ASSIGNED
(Reporter)

Comment 5

4 years ago
Comment on attachment 8596610 [details]
MozReview Request: bz://1096761/dminor

https://reviewboard.mozilla.org/r/7503/#review6281

Ship It!
Attachment #8596610 - Flags: review?(gps) → review+
(Assignee)

Comment 6

4 years ago
Thanks, pushed to https://hg.mozilla.org/hgcustom/version-control-tools/rev/002c9c5b51aa
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Comment 7

4 years ago
Comment on attachment 8596610 [details]
MozReview Request: bz://1096761/dminor
Attachment #8596610 - Attachment is obsolete: true
Attachment #8618590 - Flags: review+
(Assignee)

Comment 8

4 years ago
Created attachment 8618590 [details]
MozReview Request: testing: add test to ensure re-review of revisions does not create a new draft (bug 1096761) r=gps
(Reporter)

Updated

4 years ago
Blocks: 1179552
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.