1096761 - Pushing an identical commit should not create a draft

Status: RESOLVED FIXED

Description

[Gregory Szorc [:gps]]

Currently, when we push commits, we *always* create a new review request draft, event if nothing has changed.

I'm not 100% sure about this, but I *think* it is safe to just not create a new review request draft if nothing has changed. i.e. if the commit SHA-1 is the same, do nothing.

We may already do this. However, the push CLI says the review request is in the pending state. So, the server may be reporting state incorrectly.

I'm sure others will weigh in here...

Comment 1

[Mark Côté [:mcote]]

Dan thinks this is fixed; he'll verify.

Comment 2

[Dan Minor [:dminor]]

I was wrong, definitely not fixed.

Comment 3

[Dan Minor [:dminor]]

Created attachment 8596610 [details]
MozReview Request: bz://1096761/dminor

/r/7505 - testing: add test to ensure re-review of revisions does not create a new draft (bug 1096761) r=gps

Pull down this commit:

hg pull -r de1f6ca3fbb230c9e25e4082269b6d67850f6abf https://reviewboard-hg.mozilla.org/version-control-tools/

Comment 4

[Dan Minor [:dminor]]

With bug 1144085 fixed we're properly reporting whether something is a draft or not and this appears to be working as expected. I've added a test case to ensure it doesn't break in the future.

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8596610 [details]
MozReview Request: bz://1096761/dminor

https://reviewboard.mozilla.org/r/7503/#review6281

Ship It!

Comment 6

[Dan Minor [:dminor]]

Thanks, pushed to https://hg.mozilla.org/hgcustom/version-control-tools/rev/002c9c5b51aa

Comment 7

[Dan Minor [:dminor]]

Comment on attachment 8596610 [details]
MozReview Request: bz://1096761/dminor

Comment 8

[Dan Minor [:dminor]]

Created attachment 8618590 [details]
MozReview Request: testing: add test to ensure re-review of revisions does not create a new draft (bug 1096761) r=gps