Closed Bug 1096761 Opened 11 years ago Closed 10 years ago

Pushing an identical commit should not create a draft

Categories

(MozReview Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gps, Assigned: dminor)

References

Details

Attachments

(1 file, 1 obsolete file)

Currently, when we push commits, we *always* create a new review request draft, event if nothing has changed. I'm not 100% sure about this, but I *think* it is safe to just not create a new review request draft if nothing has changed. i.e. if the commit SHA-1 is the same, do nothing. We may already do this. However, the push CLI says the review request is in the pending state. So, the server may be reporting state incorrectly. I'm sure others will weigh in here...
Dan thinks this is fixed; he'll verify.
Assignee: nobody → dminor
I was wrong, definitely not fixed.
Depends on: 1144085
Attached file MozReview Request: bz://1096761/dminor (obsolete) —
/r/7505 - testing: add test to ensure re-review of revisions does not create a new draft (bug 1096761) r=gps Pull down this commit: hg pull -r de1f6ca3fbb230c9e25e4082269b6d67850f6abf https://reviewboard-hg.mozilla.org/version-control-tools/
Attachment #8596610 - Flags: review?(gps)
With bug 1144085 fixed we're properly reporting whether something is a draft or not and this appears to be working as expected. I've added a test case to ensure it doesn't break in the future.
Status: NEW → ASSIGNED
Comment on attachment 8596610 [details] MozReview Request: bz://1096761/dminor https://reviewboard.mozilla.org/r/7503/#review6281 Ship It!
Attachment #8596610 - Flags: review?(gps) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Attachment #8596610 - Attachment is obsolete: true
Attachment #8618590 - Flags: review+
Blocks: 1179552
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: