1096898 - [Usage] Make Usage app work in Mulet

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Oleg Zasypkin [:azasypkin]]

It would be nice to have fully usable Usage app in Mulet.

At the first looks it will require several API mocks and HTML import pre-processing for DEBUG mode (for non-debug mode it's done by webapp-optimize.js)

Comment 1

[Oleg Zasypkin [:azasypkin]]

Attachment: GitHub pull request URL

Some WIP experiments

Comment 2

[Julien Wajsberg [:julienw]]

note: HTML import is done by the lazy loader lib in debug mode.

Comment 3

[Oleg Zasypkin [:azasypkin]]

(In reply to Julien Wajsberg [:julienw] from comment #2)
> note: HTML import is done by the lazy loader lib in debug mode.

Thanks for the pointer, will look into it!

Comment 4

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8520569 [details] [review]
GitHub pull request URL

Hey Guys,

Here is the initial patch to make CostControl\Usage app work in Mulet. So what should already more or less work is FTE -> Dashboard flow.

Known issues:
* drop-down menus don't work well in Mulet for some reason, didn't have time to investigate it yet;
* it doesn't work in Nightly just because Nightly doesn't provide "navigator.mozSetMessageHandler" while Mulet does. It's easy to fix if we need it.

So would be happy to have your feedback!

Thanks!

Comment 5

[Oleg Zasypkin [:azasypkin]]

Oh, and I use "app://costcontrol.gaiamobile.org" in Mulet as "chrome://b2g/content/shell.html" is incredibly slow and unstable

Comment 6

[Salvador de la Puente González [:salva]]

Comment on attachment 8520569 [details] [review]
GitHub pull request URL

Im clearing the feedback because I have some doubts I left you on GitHub, if you don't mind, please answer me and ask for my feedback again. Thank you for the effort, it should be nice if we can run Cost Control in Mulet.

Comment 7

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8520569 [details] [review]
GitHub pull request URL

(In reply to Salvador de la Puente González [:salva] from comment #6)
> Comment on attachment 8520569 [details] [review]
> GitHub pull request URL
> 
> Im clearing the feedback because I have some doubts I left you on GitHub, if
> you don't mind, please answer me and ask for my feedback again. Thank you
> for the effort, it should be nice if we can run Cost Control in Mulet.

Replied at GitHub :)

Thanks!

Comment 8

[Julien Wajsberg [:julienw]]

Comment on attachment 8520569 [details] [review]
GitHub pull request URL

I haven't tried it yet but the approach looks good

Comment 9

[Salvador de la Puente González [:salva]]

Comment on attachment 8520569 [details] [review]
GitHub pull request URL

My thoughts on GitHub. summarizing, we should file another bug for adding the lazy loader as this could cause a real bug and we should leave JS and CSS activation as part of the LazyLoader callback.

Comment 10

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8520569 [details] [review]
GitHub pull request URL

Hey Salvador,

I've rebased PR on the latest master (as patch for bug 1100915 just landed) + made some improvements.

Would you mind to review this patch?

Thanks!

Comment 11

[Salvador de la Puente González [:salva]]

Comment on attachment 8520569 [details] [review]
GitHub pull request URL

Ok. I'm not very used to deal with Mulet but I think as a first approach it's enough. Thank you again, Oleg.

Comment 12

[Oleg Zasypkin [:azasypkin]]

(In reply to Salvador de la Puente González [:salva] from comment #11)
> Comment on attachment 8520569 [details] [review]
> GitHub pull request URL
> 
> Ok. I'm not very used to deal with Mulet but I think as a first approach
> it's enough. Thank you again, Oleg.

Thanks a lot for review, Salvador! Yeah, we'll evolve it once we have starting point :)

Treeherder is green now!

Master: https://github.com/mozilla-b2g/gaia/commit/55c59d023db505f1caa0fbe1fcb14219d08bf021