Closed Bug 1096898 Opened 5 years ago Closed 5 years ago

[Usage] Make Usage app work in Mulet

Categories

(Firefox OS Graveyard :: Gaia::Cost Control, defect, minor)

ARM
Gonk (Firefox OS)
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: azasypkin, Assigned: azasypkin)

References

Details

(Whiteboard: [NaBfT])

Attachments

(1 file)

It would be nice to have fully usable Usage app in Mulet.

At the first looks it will require several API mocks and HTML import pre-processing for DEBUG mode (for non-debug mode it's done by webapp-optimize.js)
Some WIP experiments
note: HTML import is done by the lazy loader lib in debug mode.
(In reply to Julien Wajsberg [:julienw] from comment #2)
> note: HTML import is done by the lazy loader lib in debug mode.

Thanks for the pointer, will look into it!
Whiteboard: [NaBfT]
Comment on attachment 8520569 [details] [review]
GitHub pull request URL

Hey Guys,

Here is the initial patch to make CostControl\Usage app work in Mulet. So what should already more or less work is FTE -> Dashboard flow.

Known issues:
* drop-down menus don't work well in Mulet for some reason, didn't have time to investigate it yet;
* it doesn't work in Nightly just because Nightly doesn't provide "navigator.mozSetMessageHandler" while Mulet does. It's easy to fix if we need it.

So would be happy to have your feedback!

Thanks!
Attachment #8520569 - Attachment description: GitHub pull request URL (WIP) → GitHub pull request URL
Attachment #8520569 - Flags: feedback?(salva)
Attachment #8520569 - Flags: feedback?(felash)
Oh, and I use "app://costcontrol.gaiamobile.org" in Mulet as "chrome://b2g/content/shell.html" is incredibly slow and unstable
Comment on attachment 8520569 [details] [review]
GitHub pull request URL

Im clearing the feedback because I have some doubts I left you on GitHub, if you don't mind, please answer me and ask for my feedback again. Thank you for the effort, it should be nice if we can run Cost Control in Mulet.
Attachment #8520569 - Flags: feedback?(salva)
Comment on attachment 8520569 [details] [review]
GitHub pull request URL

(In reply to Salvador de la Puente González [:salva] from comment #6)
> Comment on attachment 8520569 [details] [review]
> GitHub pull request URL
> 
> Im clearing the feedback because I have some doubts I left you on GitHub, if
> you don't mind, please answer me and ask for my feedback again. Thank you
> for the effort, it should be nice if we can run Cost Control in Mulet.

Replied at GitHub :)

Thanks!
Attachment #8520569 - Flags: feedback?(salva)
Comment on attachment 8520569 [details] [review]
GitHub pull request URL

I haven't tried it yet but the approach looks good
Attachment #8520569 - Flags: feedback?(felash) → feedback+
Comment on attachment 8520569 [details] [review]
GitHub pull request URL

My thoughts on GitHub. summarizing, we should file another bug for adding the lazy loader as this could cause a real bug and we should leave JS and CSS activation as part of the LazyLoader callback.
Attachment #8520569 - Flags: feedback?(salva) → feedback+
Depends on: 1100915
Comment on attachment 8520569 [details] [review]
GitHub pull request URL

Hey Salvador,

I've rebased PR on the latest master (as patch for bug 1100915 just landed) + made some improvements.

Would you mind to review this patch?

Thanks!
Attachment #8520569 - Flags: review?(salva)
Comment on attachment 8520569 [details] [review]
GitHub pull request URL

Ok. I'm not very used to deal with Mulet but I think as a first approach it's enough. Thank you again, Oleg.
Attachment #8520569 - Flags: review?(salva) → review+
(In reply to Salvador de la Puente González [:salva] from comment #11)
> Comment on attachment 8520569 [details] [review]
> GitHub pull request URL
> 
> Ok. I'm not very used to deal with Mulet but I think as a first approach
> it's enough. Thank you again, Oleg.

Thanks a lot for review, Salvador! Yeah, we'll evolve it once we have starting point :)

Treeherder is green now!

Master: https://github.com/mozilla-b2g/gaia/commit/55c59d023db505f1caa0fbe1fcb14219d08bf021
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.