Closed Bug 1096945 Opened 11 years ago Closed 11 years ago

[Autolander] Prevent double processing of pull requests

Categories

(Firefox OS Graveyard :: Gaia::GithubBot, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::GithubBot
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

Attachments

(1 file)

[PullReq] KevinGrandon:bug_1096945_prevent_duplicate_processing to KevinGrandon:master
50 bytes, text/x-github-pull-request
kgrandon
: review+
Details | Review
I've noticed that it's occasionally possible to trigger processing of a pull request twice - e.g., we try to create two taskgraphs, and run them twice. This can cause some problems like extra commenting on bugs and such. My bet is that we're getting an update from the bug after a comment, and are not checking if we're already running integration for that pull request.
James, Greg - let me know if you guys have any comments/concerns on this. Thanks!
Comment on attachment 8521235 [details] [review] [PullReq] KevinGrandon:bug_1096945_prevent_duplicate_processing to KevinGrandon:master Everything seems to be passing so I'm going to land this now, but let me know if you guys want me to address anything.
Attachment #8521235 - Flags: review+
Keywords: checkin-needed
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: