1096964 - [rbbz] Plain Text review rendering fails when unicode is present in the review

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect, P1)

Description

[Steven MacLeod [:smacleod]]

If a review contains unicode we will fail to publish it due to a bug in our plaintext rendering code.

https://hg.mozilla.org/hgcustom/version-control-tools/file/a7462aae407b/pylib/rbbz/rbbz/diffs.py#l292

File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/rbbz/extension.py", line 349, in on_review_publishing
    {"user": user})
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/rbbz/diffs.py", line 304, in build_plaintext_review
    review.is_reply()))
  File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/rbbz/diffs.py", line 292, in render_comment_plain
    return "\n".join(lines)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 100: ordinal not in range(128)

Comment 1

[Andreas Tolfsen ❲:ato❳]

The sample that triggered this bug was:

“This will always return an empty array now.  It returned undefined when getVisibleCookies had a try…catch for importing the cookie manager.”

Removing the … character published the review successfully.

Comment 2

[Gregory Szorc [:gps]]

Attachment: MozReview Request: bz://1096964/gps

Comment 3

[Gregory Szorc [:gps]]

/r/1343 - reviewboard: create commands for interacting with reviews
/r/1345 - rbbz: handle unicode in review comments (bug 1096964)

Pull down these commits:

hg pull review -r b2c7ba42fa915db15cbe20284a516538f256f5a4

Comment 4

[Steven MacLeod [:smacleod]]

https://reviewboard.mozilla.org/r/1343/#review709

Ship It!

Comment 5

[Steven MacLeod [:smacleod]]

https://reviewboard.mozilla.org/r/1345/#review711

Ship It!

Comment 6

[Steven MacLeod [:smacleod]]

https://reviewboard.mozilla.org/r/1341/#review713

Ship It!

Comment 7

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/3c1e0024a0a9

Comment 9

[Gregory Szorc [:gps]]

Attachment: MozReview Request: rbbz: handle unicode in review comments (bug 1096964)

Comment 10

[Gregory Szorc [:gps]]

Attachment: MozReview Request: reviewboard: create commands for interacting with reviews