Closed
Bug 1097125
Opened 11 years ago
Closed 11 years ago
make |mach reftest| support testing single files
Categories
(Testing :: Reftest, defect)
Testing
Reftest
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla37
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(3 files)
987 bytes,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
2.94 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
3.59 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
It bugs me that mach doesn't support this straightforward thing. Let's fix it.
![]() |
Assignee | |
Comment 1•11 years ago
|
||
Just something I noticed while I was in the vicinity.
Attachment #8520729 -
Flags: review?(ted)
![]() |
Assignee | |
Comment 2•11 years ago
|
||
We're going to (ab)use --filter to support single-file tests, and therefore we
need --filter support for remote-ish reftests, too.
One wonders why the b2g reftest stuff uses a completely separate
@CommandProvider for this stuff, but maybe that can be fixed up another day.
Attachment #8520730 -
Flags: review?(ted)
![]() |
Assignee | |
Comment 3•11 years ago
|
||
It turns out that the easy workaround (prior to this bug) is to do:
mach reftest [options] --filter=$(basename $TEST) $(dirname $TEST)
but we can just make mach do that, and make life easier for people.
As written, the patch silently permits you to test non-existent files; I guess
we could add a check to guard against that if you like.
Attachment #8520732 -
Flags: review?(ted)
Updated•11 years ago
|
Attachment #8520729 -
Flags: review?(ted) → review+
Updated•11 years ago
|
Attachment #8520730 -
Flags: review?(ted) → review+
Comment 4•11 years ago
|
||
Comment on attachment 8520732 [details] [diff] [review]
part 2 - make |mach reftest| and related commands support single files
Review of attachment 8520732 [details] [diff] [review]:
-----------------------------------------------------------------
::: layout/tools/reftest/mach_commands.py
@@ +94,3 @@
> return files[suite]
>
> def _find_manifest(self, suite, test_file):
You might want to add a short docstring here documenting what this function returns now, since it's no longer obvious.
Attachment #8520732 -
Flags: review?(ted) → review+
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/140c9b452bf5
https://hg.mozilla.org/mozilla-central/rev/f941c8c85ae0
https://hg.mozilla.org/mozilla-central/rev/3d75b3fcfb90
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•