1097139 - French Fx10 about:home snippets are busted on all channel

Status: RESOLVED FIXED

(Snippets :: Campaign, task)

Description

[Théo Chevalier]

French snippets on about:home are completely busted (no Firefox icon, no animation, sharing buttons are broken). Looks like some code is missing, the web console is yelling.

For instance: https://snippets.mozilla.com/show/4651/

We should consider removing them ASAP if we can't fix them, currently they are pretty pointless :/

Comment 1

[Théo Chevalier]

Also, I only checked French and a couple more locale, we should check them all.

Comment 2

[[e-mail]]

Hi folks -- sitting here with Fabio. He's turning off immediately, though it will take 24 hours to fully stop. He'll be looking into the cause and finding a solution today.

Comment 3

[Osmose [:osmose, :mkelly]]

I've updated the template used for these snippets to fix the bug that was occurring (some French strings that had single quotes were being inserted into some JavaScript and not being escaped properly, this _should_ have been caught in testing but I wasn't thorough enough when I tested). I've tested the updated template on Firefox 26 and it appears to work.

I've updated the template on production; https://snippets.mozilla.com/show/4651/ is now functioning correctly. You should be able to re-enable the snippets that were disabled whenever is convenient.

French users who got the previously-broken snippet will still have to wait 24 hours if they don't want to manually clear their snippet cache. Unfortunately there's nothing we can do about that. :(

tchevalier: Once frios re-enables the french snippets, can you force-refresh your about:home and double-check that the snippets are functioning properly? (See https://wiki.mozilla.org/Websites/Snippets/about:home_101#Manually_Forcing_a_Snippet_Refresh)

Comment 4

[Théo Chevalier]

Awesome, thanks guys!

For sure, will test as soon as it's live.

Comment 5

[Fabio Rios [:frios]]

Thanks for the quick action all. Snippets were paused this morning, but were then again enabled per Mike's comments.

Confirmed users will have a delay until they can see the corrected snippet.