1097142 - sdp_copy_attr_fields does not handle rtcp_fb, setup, connection, extmap, rtr, cap_p, sctpmap, or ice_attr from sdp_attr_t

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect)

Description

[Byron Campen [:bwc]]

I suspect that we've been ok here since we never make a deep copy, but the moment we do we're in for a surprise.

Comment 1

[Byron Campen [:bwc]]

It looks like we could just remove all of this code. That would do the trick.

Comment 2

[Byron Campen [:bwc]]

Attachment: MozReview Request: bz://1097142/bwc

/r/5569 - Bug 1097142: Remove sdp_copy_attr_fields and some other unused functions.

Pull down this commit:

hg pull review -r 29a6c590cd34d41d62a5607db44520474f2ece2d

Comment 3

[Byron Campen [:bwc]]

Comment on attachment 8578999 [details]
MozReview Request: bz://1097142/bwc

Oh look! Another excuse to delete code!

Comment 4

[Martin Thomson [:mt:]]

Comment on attachment 8578999 [details]
MozReview Request: bz://1097142/bwc

https://reviewboard.mozilla.org/r/5567/#review4565

Ship It!

Comment 5

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ee9767bc676

Comment 6

[Byron Campen [:bwc]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9c8be30657ca

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9c8be30657ca

Comment 9

[Byron Campen [:bwc]]

Attachment: MozReview Request: Bug 1097142: Remove sdp_copy_attr_fields and some other unused functions.