Closed Bug 1097142 Opened 7 years ago Closed 6 years ago
_copy _attr _fields does not handle rtcp _fb, setup, connection, extmap, rtr, cap _p, sctpmap, or ice _attr from sdp _attr _t
39 bytes, text/x-review-board-request
I suspect that we've been ok here since we never make a deep copy, but the moment we do we're in for a surprise.
It looks like we could just remove all of this code. That would do the trick.
/r/5569 - Bug 1097142: Remove sdp_copy_attr_fields and some other unused functions. Pull down this commit: hg pull review -r 29a6c590cd34d41d62a5607db44520474f2ece2d
Comment on attachment 8578999 [details] MozReview Request: bz://1097142/bwc Oh look! Another excuse to delete code!
Attachment #8578999 - Flags: review?(martin.thomson)
Comment on attachment 8578999 [details] MozReview Request: bz://1097142/bwc https://reviewboard.mozilla.org/r/5567/#review4565 Ship It!
Attachment #8578999 - Flags: review?(martin.thomson) → review+
You need to log in before you can comment on or make changes to this bug.