Closed Bug 1097142 Opened 7 years ago Closed 6 years ago

sdp_copy_attr_fields does not handle rtcp_fb, setup, connection, extmap, rtr, cap_p, sctpmap, or ice_attr from sdp_attr_t

Categories

(Core :: WebRTC: Signaling, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: bwc, Assigned: bwc)

Details

Attachments

(1 file, 1 obsolete file)

I suspect that we've been ok here since we never make a deep copy, but the moment we do we're in for a surprise.
It looks like we could just remove all of this code. That would do the trick.
Attached file MozReview Request: bz://1097142/bwc (obsolete) —
/r/5569 - Bug 1097142: Remove sdp_copy_attr_fields and some other unused functions.

Pull down this commit:

hg pull review -r 29a6c590cd34d41d62a5607db44520474f2ece2d
Assignee: nobody → docfaraday
Comment on attachment 8578999 [details]
MozReview Request: bz://1097142/bwc

Oh look! Another excuse to delete code!
Attachment #8578999 - Flags: review?(martin.thomson)
Comment on attachment 8578999 [details]
MozReview Request: bz://1097142/bwc

https://reviewboard.mozilla.org/r/5567/#review4565

Ship It!
Attachment #8578999 - Flags: review?(martin.thomson) → review+
https://hg.mozilla.org/mozilla-central/rev/9c8be30657ca
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Attachment #8578999 - Attachment is obsolete: true
Attachment #8618598 - Flags: review+
You need to log in before you can comment on or make changes to this bug.